[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
daniel added a comment. @Ladsgroup I'll try to find someone to help us. If it doesn't work, please ask @thiemowmde to bring it up as a blocker at the Scrum of Scrums next Wednesday.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, suriyaa, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Southparkfan, fbstj, Matanya, Mbch331, Rxy, Jay8g, Glaisher, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
daniel added a comment. Once I13373c8859be885 is live, we should ask ops to look at https://gerrit.wikimedia.org/r/#/c/357985/ again.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, suriyaa, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Southparkfan, fbstj, Matanya, Mbch331, Rxy, Jay8g, Glaisher, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
gerritbot added a comment. Change 359004 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add redirect=force option to Special:EntityData https://gerrit.wikimedia.org/r/359004TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, suriyaa, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Southparkfan, fbstj, Matanya, Mbch331, Rxy, Jay8g, Glaisher, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
Ladsgroup added a comment. I ran out of ideas how to fix it.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, suriyaa, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Southparkfan, fbstj, Matanya, Mbch331, Rxy, Jay8g, Glaisher, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
gerritbot added a comment. Change 359004 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/extensions/Wikibase@master] Add redirect=force option to Special:EntitData https://gerrit.wikimedia.org/r/359004TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, suriyaa, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Southparkfan, fbstj, Matanya, Mbch331, Rxy, Jay8g, Glaisher, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
gerritbot added a comment. Change 358631 merged by Filippo Giunchedi: [operations/puppet@production] mediawiki: match beta wikidata with production includes https://gerrit.wikimedia.org/r/358631TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, suriyaa, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Southparkfan, fbstj, Matanya, Mbch331, Rxy, Jay8g, Glaisher, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
gerritbot added a comment. Change 358631 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi): [operations/puppet@production] mediawiki: match beta wikidata with production includes https://gerrit.wikimedia.org/r/358631TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, suriyaa, Luke081515, biplabanand, Wikidata-bugs, Snowolf, aude, Southparkfan, fbstj, Matanya, Mbch331, Rxy, Jay8g, Glaisher, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
daniel added a comment.
The current patch defines two rewrite rules:
RewriteRule ^/entity/([^.]*)$ %{ENV:RW_PROTO}://%{SERVER_NAME}/wiki/Special:EntityData/$1 [QSA]
RewriteRule ^/entity/(.*\..*)$ %{ENV:RW_PROTO}://%{SERVER_NAME}/wiki/Special:EntityData/$1 [R=303,QSA]
Requests of the form /entity/Q1234 will trigger an internal rewrite, and Special:EntityData will then trigger a 303 redirect.
Requests of the form /entity/Q1234.json will trigger a 303 redirect, and Special:EntityData will directly serve data.
This should work OK. Now we just need someone from ops to check it and merge it.
Eventually, I'd like to see a solution that uses a single rule, and adds redirect=force to the parameters for Special:EntityData. Support for this will however need to be implemented in Special:EntityData first.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
Ladsgroup added a comment. @daniel: Done. I overlooked it (it's big but still...)TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
gerritbot added a comment. Change 357985 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [operations/puppet@production] Make /entity/ redirect internal https://gerrit.wikimedia.org/r/357985TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, QZanden, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
daniel added a comment. In T119536#2938483, @thiemowmde wrote: Please correct me if I'm wrong, but this is what I understand: Your are correct, though we should also consider convenience. https://www.wikidata.org/entity/Q36661 is what we call a canonical concept URI. This is supposed to be called without a file extension, and supposed to do content negotiation. The canonical URI does not have a file extension. But being able to call /entity/Q64.json is very convenient. I'd like to keep support for it if that can be done without too much trouble. Special:EntityData is supposed to be called with a file extension. We want this to be cacheable. Yes. E.g. https://www.wikidata.org/wiki/Special:EntityData/Q36661.json is the canonical URI (and URL) of the JSON document describing Q36661. The fact that the same special page also does content negotiation is a technical detail, because the code doing this must be somewhere. Indeed. This means https://www.wikidata.org/wiki/Special:EntityData/Q36661 is a technical detail that could as well be hidden. Yes, indeed. But the URL will be used internally (that's what /entity/Q36661 gets rewritten to) to trigger content negotiation. Preventing external access while allowing internal access may not be trivial, and cause confusion. Supporting this URL externally may also be useful for testing. What am I missing? What could be the worst negative effect this change may have? I don't see any. It just needs doing.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
Esc3300 added a comment. Isn't there another step involved, depending on how people call it? http --> httpsTASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
thiemowmde added a comment. I'm all for the proposed change. Please correct me if I'm wrong, but this is what I understand: https://www.wikidata.org/entity/Q36661 is what we call a canonical concept URI. This is supposed to be called without a file extension, and supposed to do content negotiation. Special:EntityData is supposed to be called with a file extension. We want this to be cacheable. The fact that the same special page also does content negotiation is a technical detail, because the code doing this must be somewhere. This means https://www.wikidata.org/wiki/Special:EntityData/Q36661 is a technical detail that could as well be hidden. What am I missing? What could be the worst negative effect this change may have?TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
daniel added a comment. In T119536#2786208, @elf-pavlik wrote: Once again, /entity/Q1234.ttl or /entity/Q1234.json don't seem to have any purpose and such URIs should never appear anywhrere. I agree that /entity/Q1234.xyz is semantically unclear, and we don't need it. We have supported it as an undocumented shorthand for years now, though. We can remove support for this, but we should not do without consideration. In any case, we should have a mechanism that makes *sure* we never return content from an /entity/ path. That's why I proposed the force-redirect parameter. Even if we disallow Q1234.xyz, there is nothing that guarantees that Special:EntityData/Q1234 will always cause a redirect (or error). We need to add that guarantee.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
elf-pavlik added a comment. So, /entity/Q1234.ttl must not be rewritten but redirected to /wiki/Special:EntityData/Q1234.ttl, since that will return data. To ensure this, a magic parameter could be passed, something like force-redirect=true, which would force Special:EntityData to send a redirect to the canonical URL instead of serving content directly. /entity/Q1234.ttl currently does NOT appear in chain of redirects from /entity/Q1234 and it doesn't seem to serve any purpose to have URIs like /entity/Q1234.ttl appearing anywhere all together. Currently /entity/Q1234 redirects to /wiki/Special:EntityData/Q1234 which seems to handle content negotiation and redirects to /wiki/Special:EntityData/Q1234.ttl or /wiki/Special:EntityData/Q1234.json. Preferably /entity/Q1234 will directly do 303 redirect to /wiki/Special:EntityData/Q1234.ttl or /wiki/Special:EntityData/Q1234.json. Which should work if you proxy pass to /wiki/Special:EntityData/Q1234 which seems to handle content negotiation and do 303 redirect (plus should have CORS headers set) Once again, /entity/Q1234.ttl or /entity/Q1234.json don't seem to have any purpose and such URIs should never appear anywhrere.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: elf-pavlikCc: hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
elf-pavlik added a comment. Correct, +1 removing redirect to the 'in-between' page and after 301 to HTTPS doing single 303 redirect directly to content negotiated representation where in your case URI ends with .ttl, .json etc.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: elf-pavlikCc: hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
daniel added a comment. @elf-pavlik this really proposes to remove the first 303, and keep the second. But I guess that's what you mean.TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?
elf-pavlik added a comment. +1 proposal of removing second 303, which seems matching https://www.w3.org/TR/cooluris/#r303uri F4710362: 303.pngTASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: elf-pavlikCc: elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, D3r1ck01, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
