[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-13 Thread gerritbot
gerritbot added a comment. Change 473169 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.1.0 https://gerrit.wikimedia.org/r/473169TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-13 Thread gerritbot
gerritbot added a comment. Change 473169 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.1.0 https://gerrit.wikimedia.org/r/473169TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-08 Thread gerritbot
gerritbot added a comment. Change 472440 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.0.2 https://gerrit.wikimedia.org/r/472440TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-08 Thread gerritbot
gerritbot added a comment. Change 472440 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.0.2 https://gerrit.wikimedia.org/r/472440TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-08 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Oh, yeah, looks like in WikibaseLexeme we use mw.Api directly, not Wikibase’ wrapper :/TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow,

[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-08 Thread Tarrow
Tarrow added a comment. Looks like changes to just _javascript_ API's post weren't sufficient to catch some edits made to Lexemes: e.g. Adding a representation to a formTASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-08 Thread gerritbot
gerritbot added a comment. Change 472399 had a related patch set uploaded (by Tarrow; owner: Tarrow): [wikibase/_javascript_-api@master] Assert user is still logged in when doing api post https://gerrit.wikimedia.org/r/472399TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out

2018-11-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. In T124451#2216703, @Krenair wrote: Should mw.Api always set assert=user if !mw.user.isAnon()? Or even assertuser=${mw.user.getName()} in that case.TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL