[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
gerritbot added a comment. Change 473169 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.1.0 https://gerrit.wikimedia.org/r/473169TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, JJMC89, Maathavan, D3r1ck01, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
gerritbot added a comment. Change 473169 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.1.0 https://gerrit.wikimedia.org/r/473169TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, JJMC89, Maathavan, D3r1ck01, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
gerritbot added a comment. Change 472440 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.0.2 https://gerrit.wikimedia.org/r/472440TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, JJMC89, Maathavan, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
gerritbot added a comment. Change 472440 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Updated wikibase-api JS lib to 3.0.2 https://gerrit.wikimedia.org/r/472440TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, JJMC89, Maathavan, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
Lucas_Werkmeister_WMDE added a comment. Oh, yeah, looks like in WikibaseLexeme we use mw.Api directly, not Wikibase’ wrapper :/TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, JJMC89, Maathavan, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
Tarrow added a comment. Looks like changes to just _javascript_ API's post weren't sufficient to catch some edits made to Lexemes: e.g. Adding a representation to a formTASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, CucyNoiD, Nandana, NebulousIris, Gaboe420, Mh-3110, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, enigmaeth, rohitt, LawExplorer, Lewizho99, JJMC89, Maathavan, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
gerritbot added a comment. Change 472399 had a related patch set uploaded (by Tarrow; owner: Tarrow): [wikibase/_javascript_-api@master] Assert user is still logged in when doing api post https://gerrit.wikimedia.org/r/472399TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, JJMC89, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T124451: Don't make edits if a logged in user gets logged out
Lucas_Werkmeister_WMDE added a comment.
In T124451#2216703, @Krenair wrote:
Should mw.Api always set assert=user if !mw.user.isAnon()?
Or even assertuser=${mw.user.getName()} in that case.TASK DETAILhttps://phabricator.wikimedia.org/T124451EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tarrow, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine, TerraCodes, Lydia_Pintscher, Krenair, jayvdb, ZhouZ, JEumerus, HakanIST, Legoktm, hoo, Aklapper, Multichill, Nandana, Mh-3110, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, JJMC89, Jonas, Dixtosa, Mpaulson, Wikidata-bugs, aude, Bawolff, Dinoguy1000, Slaporte, csteipp, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
