[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
gerritbot added a comment. Change 355274 merged by jenkins-bot: [mediawiki/extensions/WikidataPageBanner@master] Use ParserOutput::setTOCEnabled instead of OutputPage::enableTOC https://gerrit.wikimedia.org/r/355274TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Krinkle, gerritbot, Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, Winter, Lewizho99, Maathavan, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
Jdlrobson added a comment. The database is locked at the moment, so I can't replicate the bug on labs by importing to https://en.wikivoyage.beta.wmflabs.org/wiki/Tokushima?action=""> I want to do this before merging the patch.TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Krinkle, gerritbot, Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, Winter, Lewizho99, Maathavan, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
Jdlrobson added a comment. I can also replicate this now.TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Krinkle, gerritbot, Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, Winter, Lewizho99, Maathavan, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
Krinkle added a comment. In T126361#3287295, @Jdlrobson wrote: Im somewhat hopeful T130632 will fix this. In T126361#3287353, @gerritbot wrote: Change 355274 had a related patch set uploaded (by Krinkle; owner: Krinkle): [mediawiki/extensions/WikidataPageBanner@master] Use ParserOutput::setTOCEnabled instead of OutputPage::enableTOC https://gerrit.wikimedia.org/r/355274 Indeed. T130632 moves the logic of loading mediawiki.toc from Parser to Skin. It also removes support to toggle TOC via OutputPage. Instead, this should happen via ParserOutput directly (via the same hook). This way it will also be considered by EditPage Preview, Live Preview, and the Parse API – which is what Parsoid and VisualEditor use.TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, gerritbot, Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, Winter, Lewizho99, Maathavan, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
gerritbot added a comment. Change 355274 had a related patch set uploaded (by Krinkle; owner: Krinkle): [mediawiki/extensions/WikidataPageBanner@master] Use ParserOutput::setTOCEnabled instead of OutputPage::enableTOC https://gerrit.wikimedia.org/r/355274TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, QZanden, merbst, Winter, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
Elitre added a comment. No, because I also reproduced on Safari on an Air.TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ElitreCc: Elitre, Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, QZanden, merbst, Winter, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126361: Wrong style of Table of Contents displays when saving a page at Wikivoyage
Whatamidoing-WMF added a comment. I can: F8101152: Screen Shot 2017-05-16 at 11.57.35 AM.png Perhaps it's Firefox only?TASK DETAILhttps://phabricator.wikimedia.org/T126361EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Whatamidoing-WMFCc: Jdlrobson, Aklapper, Whatamidoing-WMF, Robinma, GoranSMilovanovic, QZanden, merbst, Winter, Wess, Izno, Jrf, Husun1297, Wikidata-bugs, aude, Swainr, Lydia_Pintscher, Jdforrester-WMF, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
