[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Esc3300 added a comment. I think you should add : 4. undo semi-"merge" TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Addshore, Pasleim, Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Addshore added a comment. The current behaviour is exactly as it was designed, you cant technically merge something that has conflicts. If you try to merge two items that both an an enwiki sitelink then you are probably doing something wrong and should resolve the conflict before merging. Having the merge api automatically discard conflicts would mean you could merge Q1 with Q2 and nothing would complain. In T127213#2691919, @hoo wrote: We never automatically deleted items, but users did that with scripts. Indeed, and if a user desires this is: call wbmergeitems call wbeditentity to clear the item call wbcreateredirect TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Pasleim, Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
hoo added a comment. In T127213#2691902, @Esc3300 wrote: It seems that initially items were merged into one and then the other deleted. This might just be a leftover from that. We never automatically deleted items, but users did that with scripts.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Pasleim, Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Esc3300 added a comment. It seems that initially items were merged into one and then the other deleted. This might just be a leftover from that.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Pasleim, Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Esc3300 added a comment. In T127213#2691838, @hoo wrote: In T127213#2691830, @Esc3300 wrote: I don't think it should abandon the merger half way through. It doesn't, it fully completes the merge, but doesn't create the redirect. Well, yes and no. There are two ways of seeing it. Currently Pasleim's bot just cleans up behind. Generally this is fine, but sometimes it isn't.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Nikki added a comment. I think it shouldn't allow a merge unless it is also going to create a redirect - either the merge is good and both parts should be done, or the merge is bad and neither should be done. Doing one but not the other always (as far as I can tell) creates a situation where someone needs to fix it afterwards. The way the merge gadget behaves is pretty intuitive to me. That blanks any remaining descriptions before creating the redirect. There is also a bot (PLbot?) which attempts to find and fix partial merges which does the same thing. If someone is going to do a merge that ignores conflicting descriptions, removing any conflicting descriptions so that a redirect can be created would be the best option in my opinion and also the most consistent. I can't really comment on ignoring sitelink conflicts because I would expect any merge with sitelink conflicts to be prevented. The first paragraph I wrote though would suggest that if people/things are going to be allowed to do merges which explicitly ignore sitelink conflicts, the conflicting sitelinks should be removed so that the item can be redirected.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NikkiCc: Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
hoo added a comment. This is desired behavior and applies equally to ignoreconflicts=description and ignoreconflicts=sitelink (and combinations of both). Basically if either or both of these are set, we will just leave the conflicting piece of data (description or sitelink) on the Item we're merging from. As non-empty Items can't be turned into redirects, we can't automatically do that in the next steps (without having to "throw away" the data). If we want to change this behavior, we need to decide what we want to do with the conflicting data in such cases.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Magnus added a comment. Now switched to "ignoreconflicts:description".TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagnusCc: Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Esc3300 added a comment. I'd use "description" or "description|statements". Statements is probably to avoid that items linking to each other don't get merged. To be safe, use "description". Obviously, there is still the bug that sometimes the api doesn't work .. but this is what this bug was originally about.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Magnus added a comment. So what should I set "ignore" to? Phrased differently: With which settings will wbmergeitems fail and not edit the item, in case of non-resolvable conflict?TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagnusCc: Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Esc3300 added a comment. Looking the source of QuickStatements, it seems to use ignore conflicts = sitelinks. https://bitbucket.org/magnusmanske/wikidata-todo/src/0bfdfdb727913ff71b2d6ea49949d4203d122c3a/scripts/quick_statements.php?at=master=file-view-default This probably explains the problem.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Lydia_Pintscher, Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
Nikki added a comment. @Esc3300: I'm not sure that it's a good idea to combine your case with the problem I originally reported where the merges should have been completed, not prevented. They have different expected behaviour and I think your case should be a higher priority, which I assume would need a separate ticket. For now I've edited the description to clarify that I'm not asking for all of the merges I originally listed to be prevented. (Phabricator doesn't clearly show that other people have edited the description, let alone added whole new paragraphs...)TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NikkiCc: Esc3300, Magnus, matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T127213: [Bug] Merging doesn't always create a redirect
matej_suchanek added a comment. I'm not sure how the users are creating the edits, but it seems like unintended behaviour. Propably with the client sitelink widget. In T127213#2035936, @Mbch331 wrote: When they use Special:MergeItems no redirect is created when there is a conflict with descriptions. Rest of the merge is performed. Don't know if the user gets an error message. The merge gadget has a workaround to make sure a redirect is created. Do you know this, or think? I usually get the error message and no merge is initiated. AFAIK, sitelink widget blocks merge and reports error on statement and/or sitelink conflict but does niether on description conflict which causes these merges not to complete.TASK DETAILhttps://phabricator.wikimedia.org/T127213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, hoo, Mbch331, Aklapper, Nikki, StudiesWorld, D3r1ck01, Izno, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
