[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-05 Thread gerritbot
gerritbot added a comment. Change 325038 abandoned by Jdlrobson: Add check if $options['isAutomatic'] is true Reason: Whoops.. I see the patch from Thiemo uses empty so I think this is no longer needed. Let me know if I've got that wrong.. Thanks for all the patches! Please keep contributing!!

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-05 Thread gerritbot
gerritbot added a comment. Change 325038 restored by Jdlrobson: Add check if $options['isAutomatic'] is true https://gerrit.wikimedia.org/r/325038TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsn,

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-02 Thread gerritbot
gerritbot added a comment. Change 325038 abandoned by Divadsn: Add check if $options['isAutomatic'] is true Reason: See change 324884. https://gerrit.wikimedia.org/r/325038TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-02 Thread gerritbot
gerritbot added a comment. Change 325038 had a related patch set uploaded (by Divadsn): Add check if $options['isAutomatic'] is true https://gerrit.wikimedia.org/r/325038TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-02 Thread divadsn
divadsn added a comment. @Jdlrobson what do you mean with this comment here? How should I avoid sending the image to the template when we don't know about the image aspect ratio at that point? https://gerrit.wikimedia.org/r/#/c/324775/4/includes/WikidataPageBanner.hooks.php@128TASK

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-01 Thread gerritbot
gerritbot added a comment. Change 324775 merged by jenkins-bot: Fix badly cropped images when using page images https://gerrit.wikimedia.org/r/324775TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsn,

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-01 Thread gerritbot
gerritbot added a comment. Change 324775 had a related patch set uploaded (by Divadsn): Fix badly cropped images when using page images https://gerrit.wikimedia.org/r/324775TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-12-01 Thread gerritbot
gerritbot added a comment. Change 324775 had a related patch set uploaded (by Divadsn): Fix badly cropped images when using page images https://gerrit.wikimedia.org/r/324775TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-30 Thread Sumit
Sumit added a comment. @divadsn I go by the nick "codezee" on #mediawiki and #wikimedia-mobile on irc. You can ping for help if facing difficulty...TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: divadsn,

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-30 Thread Sumit
Sumit added a comment. In T131424#2836147, @divadsn wrote: @Jdlrobson Thank you for the clarification, now I will setup my dev environment. One question, will vagrant run fine on a old laptop with 4 GB RAM and Ubuntu 16.10 64-bit installation? @divadsn it should be fine but feel free to ask on

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-30 Thread divadsn
divadsn added a comment. @Jdlrobson Thank you for the clarification, now I will setup my dev environment. One question, will vagrant run fine? on a old laptop with 4 GB RAM and Ubuntu 16.10 64-bit installation?TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-30 Thread Jdlrobson
Jdlrobson added a comment. Hi @divadsn - to be more specific any images where the width of the image is less than 1.5 * height. width:200px, height: 200px would not be allowed (200 < 1.5 * 200) This should only apply to images generated automatically. {{PAGEBANNER:SmallImage}} would still work as

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-30 Thread divadsn
divadsn added a comment. I will work to fix it in the next 2 days as a Google Code-in student. As far as I understood the task is to find the corresponding code section and add a check if the image is not landscape, right?TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-29 Thread Sumit
Sumit added a comment. In T131424#2830972, @Aklapper wrote: @Jdlrobson: To clarify, would you like to mentor this in #Google-Code-In-2016 (as you added that tag)? Or maybe @Nirzar (see info)? :) Imported as https://codein.withgoogle.com/dashboard/tasks/6225877616558080/ I'll be mentoring this

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-28 Thread Nirzar
Nirzar added a comment. @Sumit yes. 1.5 is a usual conversion factor we use for landscape and portrait. width < 1.5 * height. thanks @SumitTASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NirzarCc: Dbrant,

[Wikidata-bugs] [Maniphest] [Commented On] T131424: WikidataPageBanner when using page images generated API renders badly cropped images

2016-11-28 Thread Sumit
Sumit added a comment. does a general solution to ignore banner if image width < 2 *(image height) look acceptable?TASK DETAILhttps://phabricator.wikimedia.org/T131424EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SumitCc: Jhernandez, Sumit, KHammerstein,