[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Addshore added a comment. In T138104#5741769 , @Ladsgroup wrote: > In T138104#5739133 , @Pablo-WMDE wrote: > >> As always I admire the courageous behavior but changing wikibase'

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 557002 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Default “serialize empty lists as objects” to true https://gerrit.wikimedia.org/r/557002 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Pablo-WMDE added a comment. > I think the proper communication channel for wikibase given that it's a software is to have a note in RELEASE-NOTES.md for 1.35 and simply remove it. Similar to what happens in mediawiki. I agree, changelog documents versioned with the software are a

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Ladsgroup added a comment. In T138104#5739133 , @Pablo-WMDE wrote: > As always I admire the courageous behavior but changing wikibase' default behavior (be it through removal of the config //or// inversion of its default value) is

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Pablo-WMDE added a comment. As always I admire the courageous behavior but changing wikibase' default behavior (be it through removal of the config //or// inversion of its default value) is worth funneling the news through the appropriate channels. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 557004 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Remove “serialize empty lists as objects” setting https://gerrit.wikimedia.org/r/557004 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 557002 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Default “serialize empty lists as objects” to true https://gerrit.wikimedia.org/r/557002 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Ladsgroup added a comment. In T138104#5739073 , @Pablo-WMDE wrote: > It appears the installations configured by operations/mediawiki-config (wikidata et al) do the expected due to 49 , 507030

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Pablo-WMDE added a comment. It appears the installations configured by operations/mediawiki-config (wikidata et al) do the expected due to 49 , 507030 ff. However, default wikibase installations still

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 555937 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [wikibase/termbox@master] EntityInitializer: unlearn fix for poor serialization https://gerrit.wikimedia.org/r/555937 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-04-30T11:15:48Z] Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:507032|Serialize empty lists as objects on Commons (T138104 )]] (duration: 00m 54s) TASK

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507032 **merged** by jenkins-bot: [operations/mediawiki-config@master] Serialize empty lists as objects on Commons https://gerrit.wikimedia.org/r/507032 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-04-30T11:12:00Z] Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:507031|Serialize empty lists as objects on Wikidata (T138104 )]] (duration: 00m 55s) TASK

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507031 **merged** by jenkins-bot: [operations/mediawiki-config@master] Serialize empty lists as objects on Wikidata https://gerrit.wikimedia.org/r/507031 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-04-29T18:37:16Z] Synchronized wmf-config/InitialiseSettings.php: Serialize empty lists as objects on Test Commons (T138104 ) (duration: 00m 54s) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-04-29T18:30:15Z] Synchronized wmf-config/InitialiseSettings.php: Serialize empty lists as objects on Test Wikidata (T138104 ) (duration: 00m 53s) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507034 **merged** by jenkins-bot: [operations/mediawiki-config@master] Serialize empty lists as objects on Test Commons https://gerrit.wikimedia.org/r/507034 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507030 **merged** by jenkins-bot: [operations/mediawiki-config@master] Serialize empty lists as objects on Test Wikidata https://gerrit.wikimedia.org/r/507030 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lucas_Werkmeister_WMDE added a comment. On second thought, I’ve moved the two test wiki changes to today’s Morning SWAT, so they can get a bit of testing in overnight. (I don’t think our announcement covered Test Wikidata.) TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lucas_Werkmeister_WMDE added a comment. All four config changes scheduled for tomorrow’s EU SWAT (13:00 CEST). TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507034 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Serialize empty lists as objects on Test Commons https://gerrit.wikimedia.org/r/507034 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lucas_Werkmeister_WMDE added a comment. The current stable interface policy seems to be specific to Wikidata only – > This **Stable Interface Policy** defines which guarantees are and are not given by the Wikidata development team

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507031 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Serialize empty lists as objects on Wikidata https://gerrit.wikimedia.org/r/507031 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507032 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Serialize empty lists as objects on Commons https://gerrit.wikimedia.org/r/507032 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 507030 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Serialize empty lists as objects on Test Wikidata https://gerrit.wikimedia.org/r/507030 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lucas_Werkmeister_WMDE added a comment. I just realized this affects Commons as well (example entity data with empty list as descriptions ). Does the stable interface policy apply there? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lea_Lacroix_WMDE added a comment. This is due to be enabled tomorrow (30.4.). Is anyone monitoring it? TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lea_Lacroix_WMDE Cc: Nirmos,

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 502826 **merged** by jenkins-bot: [wikibase/termbox@master] Replace empty arrays with empty objects in EntityInitializer https://gerrit.wikimedia.org/r/502826 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 502826 had a related patch set uploaded (by Jakob; owner: Jakob): [wikibase/termbox@master] Replace empty arrays with empty objects in EntityInitializer https://gerrit.wikimedia.org/r/502826 TASK DETAIL https://phabricator.wikimedia.org/T138104

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 502826 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Jakob): [wikibase/termbox@master] Replace empty arrays with empty objects in EntityInitializer https://gerrit.wikimedia.org/r/502826 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lea_Lacroix_WMDE added a comment. Here's the current process running, according to our stable interface policy: ✅ April 2nd - Announcement ✅ Test system available (min. 2 weeks before deployment) ⬜ April 30th -

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lucas_Werkmeister_WMDE added a comment. I did, it was a different problem – the beta-scap-eqiad job hadn’t finished yet (I had only waited for beta-mediawiki-config-update-eqiad

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Ladsgroup added a comment. In T138104#5075483 , @Lucas_Werkmeister_WMDE wrote: > Hm, the config change should be deployed on Beta, but I’m still getting empty lists instead of empty objects there. I had similar issue, make sure

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lucas_Werkmeister_WMDE added a comment. Hm, the config change should be deployed on Beta, but I’m still getting empty lists instead of empty objects there. TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-04-01T18:10:02Z] Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:49|Add tmpSerializeEmptyListsAsObjects Wikibase repo config (T138104 )]] (duration: 00m

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 49 **merged** by jenkins-bot: [operations/mediawiki-config@master] Add tmpSerializeEmptyListsAsObjects Wikibase repo config https://gerrit.wikimedia.org/r/49 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 49 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [operations/mediawiki-config@master] Add tmpSerializeEmptyListsAsObjects Wikibase repo config https://gerrit.wikimedia.org/r/49 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 493096 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add metadata to Special:EntityData output when config is set https://gerrit.wikimedia.org/r/493096 TASK DETAIL https://phabricator.wikimedia.org/T138104 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

gerritbot added a comment. Change 493096 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Add metadata to Special:EntityData output when config is set https://gerrit.wikimedia.org/r/493096 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Addshore added a comment. We should probably announce this change, as clients expecting the old / wrong thing could break. From: https://www.wikidata.org/wiki/Wikidata:Stable_Interface_Policy Breaking change: a change to an API or data format that violates guarantees given or widely assumed

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

NoInkling added a comment. Here's a new example that's currently missing everything except claims, since the original was updated: https://www.wikidata.org/wiki/Special:EntityData/Q61519072.json As I noted elsewhere, it might not be such a big deal for _javascript_ clients since JS syntax/APIs

[Wikidata-bugs] [Maniphest] [Commented On] T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Lucas_Werkmeister_WMDE added a comment. It looks like this affects the live JSON returned by Special:EntityData, but not the JSON found in the dumps – the dumps have "description":{}.TASK DETAILhttps://phabricator.wikimedia.org/T138104EMAIL