[Wikidata-bugs] [Maniphest] [Commented On] T142203: DuplicateReferences: insertReference triggers TypeError

2016-09-21 Thread Josve05a
Josve05a added a comment. Well, worked fine for me :) but if there are more things to fix, maybe a new ticket...TASK DETAILhttps://phabricator.wikimedia.org/T142203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Josve05aCc: Jklamo, Thryduulf, Josve05a,

[Wikidata-bugs] [Maniphest] [Commented On] T142203: DuplicateReferences: insertReference triggers TypeError

2016-09-21 Thread Sjoerddebruin
Sjoerddebruin added a comment. Well, the basic function is working. No need to reopen this task imo. Could create separate tasks for the things that still need to be done.TASK DETAILhttps://phabricator.wikimedia.org/T142203EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T142203: DuplicateReferences: insertReference triggers TypeError

2016-09-08 Thread Sjoerddebruin
Sjoerddebruin added a comment. In T142203#2617033, @adrianheine wrote: Right solution for this would be to have a top-level WikibaseRepo factory WikibaseRepo with a method getEntityChangersFactory. The EntityChangersFactory could then be used to get a StatementsChanger. Would you be able to do

[Wikidata-bugs] [Maniphest] [Commented On] T142203: DuplicateReferences: insertReference triggers TypeError

2016-09-07 Thread adrianheine
adrianheine added a comment. Right solution for this would be to have a top-level WikibaseRepo factory WikibaseRepo with a method getEntityChangersFactory. The EntityChangersFactory could then be used to get a StatementsChanger.TASK DETAILhttps://phabricator.wikimedia.org/T142203EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T142203: DuplicateReferences: insertReference triggers TypeError

2016-09-07 Thread Sjoerddebruin
Sjoerddebruin added a comment. Deployment has just taken place, gadget is broken again: TypeError: undefined is not an object (evaluating 'statementview._controller._model')TASK DETAILhttps://phabricator.wikimedia.org/T142203EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T142203: DuplicateReferences: insertReference triggers TypeError

2016-08-05 Thread Sjoerddebruin
Sjoerddebruin added a comment. The gadget is working again, see here. It is only a temporary solution though. What is needed to fix this properly?TASK DETAILhttps://phabricator.wikimedia.org/T142203EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: