gerritbot added a comment.
Change 321369 abandoned by Addshore:
WPB enable banners on diff pages
https://gerrit.wikimedia.org/r/321369
TASK DETAIL
https://phabricator.wikimedia.org/T147946
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
Tgr added a comment.
The page title is set in `DifferenceEngine::showDiffPage`, you'd have to
factor out that part into something that can be sanely overridden. Or, I guess,
change the title from the DifferenceEngineOldHeaderNoOldRev and
DifferenceEngineOldHeader hooks, although that's a
Andyrom75 added a comment.
@Jdlrobson I can't belive that showing banner in diff pages (as happened
before) is technically not feasible. Could you refresh the status of this task
and eventually give us some feedback?
TASK DETAIL
https://phabricator.wikimedia.org/T147946
EMAIL PREFERENCES
Andyrom75 added a comment.
The old banner hid the page title and created a dedicated new title for the banner, maybe that's way in the old implementation this problem has never occur.
Is it possible to implement the banner in the same way?TASK DETAILhttps://phabricator.wikimedia.org/T147946EMAIL
Jdlrobson added a comment.
The diff is shown where-ever the title is (which usually happens to be the top of the page and the top of the article)
However, on this diff page
"Differenze tra le versioni di "Utente:Pietro Di Fontana" is considered the title of the page and the actual title of the
Andyrom75 added a comment.
I agree that the very top of the page it's not the right place for the banner. The right place is its real position: at the top of the article (below the diff) and not at the top of the page.
As explained before, is an issue not seeing the banner and it must be
Jdlrobson added a comment.
It's trivial to show the banner again but I'm concerned that showing it at the top of the diff page will make it harder for patrollers to patrol given it will hide the rest of the diff on a small resolution. Given the opposite opinion it would be extremely helpful if
Andyrom75 added a comment.
Maybe I'm wrong but since the banner it's just a normal picturre (nothing more, nothing less), I suppose that has been use some code to hide it, so it should be enough to remove/bypass that code.TASK DETAILhttps://phabricator.wikimedia.org/T147946EMAIL
Jdlrobson added a comment.
[Seems more complicated then we originally hoped]TASK DETAILhttps://phabricator.wikimedia.org/T147946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Nirzar, gerritbot, Tgr, Nicolas_Raoul, Sumit, Jdlrobson, Aklapper,
Jdlrobson added a comment.
@Sumit's patch puts the banner ABOVE the diff.
I worry this might be distracting to those who just want to view the diff.
F4724729: Screen Shot 2016-11-14 at 4.24.19 PM.png
It also doesn't show the title/display title
@Nicolas_Raoul @Andyrom75 how would you expect this
gerritbot added a comment.
Change 321369 had a related patch set uploaded (by Sumit):
WPB enable banners on diff pages
https://gerrit.wikimedia.org/r/321369TASK DETAILhttps://phabricator.wikimedia.org/T147946EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Jdlrobson added a comment.
@Sumit all conversations are archived but we'd have to search and find the conversation. I think the issue will be the fact that usually the banner takes over the title of the page and in this case it would not - it would render under the diff. It might be tricky to
Sumit added a comment.
In T147946#2723577, @Jdlrobson wrote:
I agree and I'm regretful that I wasn't more verbose in that task. If I created it, I suspect there was a good reason - e.g. a discussion on Wikivoyage or there was a technical barrier to doing so. Hoping we can shed some light on the
Andyrom75 added a comment.
Hi @Jdlrobson, do you think that more verifications are needed or is already possible to restore the normal visualization of the diff pages?TASK DETAILhttps://phabricator.wikimedia.org/T147946EMAIL
Jdlrobson added a comment.
I agree and I'm regretful that I wasn't more verbose in that task. If I created it, I suspect there was a good reason - e.g. a discussion on Wikivoyage or there was a technical barrier to doing so. Hoping we can shed some light on the issue and get it fixed. Thanks for
15 matches
Mail list logo
