[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-04-21 Thread gerritbot
gerritbot added a comment. Change 339655 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Move cheap checks up in LinkBeginHookHandler::doOnLinkBegin https://gerrit.wikimedia.org/r/339655TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-04-20 Thread gerritbot
gerritbot added a comment. Change 339654 merged by WMDE-leszek: [mediawiki/extensions/Wikibase@master] Refactor foreign EntityId parsing in LinkBeginHookHandler https://gerrit.wikimedia.org/r/339654TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-04-20 Thread gerritbot
gerritbot added a comment. Change 340523 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Minor refactoring of foreign EntityId parsing in LinkBeginHookHandler https://gerrit.wikimedia.org/r/340523TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-04-18 Thread thiemowmde
thiemowmde added a comment. Oh, thanks. I forgot to look at the priority field.TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, thiemowmdeCc: thiemowmde, gerritbot, daniel, Aklapper, Lydia_Pintsch

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-03-02 Thread gerritbot
gerritbot added a comment. Change 340524 abandoned by Thiemo Mättig (WMDE): Refactor foreign EntityId parsing in LinkBeginHookHandler, step 2 Reason: I did not assigned anybody on purpose because I wanted to see if this fails. It does not, which leaves me puzzled. https://gerrit.wikimedia.org/r/3

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-03-01 Thread gerritbot
gerritbot added a comment. Change 340523 had a related patch set uploaded (by Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase] Refactor foreign EntityId parsing in LinkBeginHookHandler, step 1 https://gerrit.wikimedia.org/r/340523TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREF

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-03-01 Thread gerritbot
gerritbot added a comment. Change 340524 had a related patch set uploaded (by Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase] Refactor foreign EntityId parsing in LinkBeginHookHandler, step 2 https://gerrit.wikimedia.org/r/340524TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREF

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-02-24 Thread gerritbot
gerritbot added a comment. Change 336623 merged by jenkins-bot: Parse foreign entity page links in LinkBeginHookHandler https://gerrit.wikimedia.org/r/336623TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WM

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-02-24 Thread gerritbot
gerritbot added a comment. Change 339654 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Refactor foreign EntityId parsing in LinkBeginHookHandler https://gerrit.wikimedia.org/r/339654TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-02-24 Thread gerritbot
gerritbot added a comment. Change 339655 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Move check checks up in LinkBeginHookHandler::doOnLinkBegin https://gerrit.wikimedia.org/r/339655TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-02-08 Thread WMDE-leszek
WMDE-leszek added a comment. https://gerrit.wikimedia.org/r/336623 is my take on option 1.TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, daniel, Aklapper, Lydia_Pintscher, WMDE-lesz

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-02-08 Thread gerritbot
gerritbot added a comment. Change 336623 had a related patch set uploaded (by WMDE-leszek): Parse foreign entity page links in LinkBeginHookHandler https://gerrit.wikimedia.org/r/336623TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/p

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-02-06 Thread daniel
daniel added a comment. Thinking about it now, I think I prefer option 1 as a first step, even though it's kind of dirty (parsing links, eww). We can look into option 2 later, but it seems a bit involved and brittle.TASK DETAILhttps://phabricator.wikimedia.org/T157004EMAIL PREFERENCEShttps://phabri

[Wikidata-bugs] [Maniphest] [Commented On] T157004: Edit summary should include the label of foreign entities

2017-02-06 Thread daniel
daniel added a comment. The issue here is how SummaryFormatter and LinkBeginHookHandler interact: SummaryFormatter uses a EntityIdPlainLinkFormatter to generate wiki-links for each entity. LinkBeginHookHandler recognized links to entity pages, and automatically looks up the entity's label and use