[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jakob_WMDE added a comment. I'll move this to done for now. If we want to add the title attribute we can open another ticket for that.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jakob_WMDE added a comment. @Jan_Dittrich It is possible to add the title attribute. Ideally this would be a message that works for items and properties, since the selector widget is generic and only gets the entity type passed as a parameter for the API request. It's not impossible to have specific messages for the two types though, just a little ugly code-wise.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jan_Dittrich added a comment. In this case it might be worth considering removing any marking from the accepted term and just leave it as is to make the difference stand out more since there are only two states to consider, correct? Yes, would be OK with me. We should add a title= attribute though that allows to get a popup with "value recognized"/"Value not recognized. Choose one from the suggestions" (and same for other input types, but with the type instead of "Value" and possibly without the "Choose…" if the type does not have suggestions) @Jakob_WMDE: Is the title="… possible to add to the field?TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Jan_DittrichCc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
gerritbot added a comment. Change 375008 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Avoid !important in entityselector where not necessary https://gerrit.wikimedia.org/r/375008TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
gerritbot added a comment. Change 375008 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase@master] Avoid !important in entityselector where not necessary https://gerrit.wikimedia.org/r/375008TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
gerritbot added a comment. Change 370628 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Indicate recognized/unrecognized input in entityselector. https://gerrit.wikimedia.org/r/370628TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jakob_WMDE added a comment. The latest patch has the icon-less version for now.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Charlie_WMDE added a comment. I agree with @abian in that a more stylized x could be beneficial although I also see how the current x does not suggest clickability just from its appearance. I also agree that the two check marks next to each other are not a very elegant solution. We could also consider not using the symbols at all. This would make it less accessible for colorblind people though, although a color change should still be recognizable. In this case it might be worth considering removing any marking from the accepted term and just leave it as is to make the difference stand out more since there are only two states to consider, correct? @Jan_Dittrich @Lydia_PintscherTASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Charlie_WMDECc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
abian added a comment. Some users can expect the x to be clickable with the purpose of cleaning the field (or even closing/ignoring something), as that's usually the behaviour of the regular x in WIMP. I think that a more stylized x, another symbol or a different idea could avoid this confusion. F9147895: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, abianCc: abian, gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Lydia_Pintscher added a comment. Those mockups look good to me.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Lydia_PintscherCc: gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jan_Dittrich added a comment. Would that work for properties and values? I assume it should be considered that properties and value display might look differently in the future.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Jan_DittrichCc: gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jan_Dittrich added a comment. So I created a plausible error state: F9147895: image.png …the "recognized" state is more difficult.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Jan_DittrichCc: gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jakob_WMDE added a comment. @James_Budday the current patch is more of a proof of concept (not meant to be merged this way) and simply highlights the input field in bright red or green. Let me know if you have a suggestion for what this could look like!F9075792: Screen Shot 2017-08-15 at 11.48.46.pngTASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
James_Budday added a comment. @Jakob_WMDE can you add a screenshot of what the current patch would look like?TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, James_BuddayCc: gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
gerritbot added a comment. Change 370628 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] [WIP] Indicate recognized/unrecognized input in entityselector. https://gerrit.wikimedia.org/r/370628TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jan_Dittrich added a comment. @Jakob_WMDE No particular input yet I think last week we decided to highlight the input field according to its status as a first step without any pill behavior. Yes. There was the open question of highlighting the whole item in orange (like we do at another error occasion – is there any screenshot of it?) or just highlighting the input field. I would opt for the latter.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Jan_DittrichCc: Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jakob_WMDE added a comment. @Jan_Dittrich any update on what this should look like? I think last week we decided to highlight the input field according to its status as a first step without any pill behavior.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Jan_Dittrich added a comment. look like the input field could handle multiple values. @Sjoerddebruin : Yes, that is a good point. We should reconsider and find an alternative to a pill while still showing that the input was recognized by the system.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Jan_DittrichCc: Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
Sjoerddebruin added a comment. But the pill does look like the input field could handle multiple values. This would be interesting for values(!),but confusing for properties.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, SjoerddebruinCc: Sjoerddebruin, Jonas, PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
James_Budday added a comment.Herald added a subscriber: PokestarFan. These images come from a blog post about design and accessibility. They were intended to illustrate the purpose of using more than one kind of signal to show the error state in a form. F8833585: image.png F8833593: image.png Mostly posting here for reference.TASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: James_BuddayCc: PokestarFan, James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T170531: Semantics: Make recognized property and value look different than unrecognized input
James_Budday added a comment. When a user has entered something that doesn't match a property, there should also be some indicator of the fact that it won't be accepted as input. Gmail does a red underline as if the word was misspelled for example. Accepted: F8729444: accepted.png Not accepted: F8729484: unaccepted.pngTASK DETAILhttps://phabricator.wikimedia.org/T170531EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: James_BuddayCc: James_Budday, Charlie_WMDE, thiemowmde, Lydia_Pintscher, Aklapper, Jan_Dittrich, GoranSMilovanovic, QZanden, JGirault, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
