gerritbot added a comment.
Change 371470 merged by jenkins-bot:
[wikidata/query/gui@master] Temporarily disable highlighting parse errors
https://gerrit.wikimedia.org/r/371470TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/email
gerritbot added a comment.
Change 371470 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/gui@master] Temporarily disable highlighting parse errors
https://gerrit.wikimedia.org/r/371470TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://ph
Jonas added a comment.
This is the line to disable the SPARQL.js error highlight
https://github.com/wikimedia/wikidata-query-gui/blob/master/wikibase/queryService/ui/App.js#L262TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai
Fnielsen added a comment.
I think someone pointed to error-line{border-bottom:2px dotted red} (I forgot who). https://query.wikidata.org/css/style.min.0d7eafbda8bb1aa11051.css. Changing red to white seems to do it.TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabrica
Smalyshev added a comment.
I wonder how hard would it be yo just temporarily remove the dots thing altogether, pending the upstream fix. We can keep the syntax highlighting, but drop the dots part for a while.TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.w
Esc3300 added a comment.
I just want to know why we got an incompatible syntax highlighter.
I'm sure the highlighter is perfectly helpful on other websites, but the GUI at Wikidata Query Service has deteriorated and this is one of its cause.
It's possible that the discussion of this shouldn't tak
Jonas added a comment.
So, I am a little confused about the escalation here ...
We reported the problem upstream.
For me it seems named sub queries are a rare edge case only used by experts.
We should empathize with beginners and think of the usefulness of that feature for them.
It is just a opti
Fnielsen added a comment.
In my opinion it is not outside the component developer, as the SPARQL.js just could be disabled here on WDQS. In my opinion the red dots confuse more than syntax highlighting helps (when there is no WITH). If WDQS could be personalized I would switch SPARQL.js off.TASK DE
Izno added a comment.
In T171935#3516719, @Jonas wrote:
Reported to upstream:
https://github.com/RubenVerborgh/SPARQL.js/issues/43
This should be Stalled or Open, not Resolved, if the task is an upstream fix, only to be closed when we get a pull from upstream.TASK DETAILhttps://phabricator.wiki
Esc3300 added a comment.
As fixing WITH highlighting was declined (T171934) can we just get rid of this feature? It isn't of much use if it's based on wrong assumptions.TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefere
Fnielsen added a comment.
@Smalyshev Try to add an empty newline at the top. That usually does it.TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FnielsenCc: Fnielsen, Smalyshev, Jonas, Aklapper, Esc3300, Pok
Smalyshev added a comment.
Interestingly enough, what I see with the query above is just "WITH {" being underlined, but the rest is fine. Browser differences?TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Sm
Fnielsen added a comment.
With http://tinyurl.com/y9ekltr7 WITH and its parts in "{ ... }" get sometimes dotted and I agree that it is distracting. It would be better with SPARQL.js switched off then or something like
.error-line {
border-bottom: 2px dotted white;
}
Or whatever.TASK DETAILhtt
Esc3300 added a comment.
Depending on the query, half the page is red and the query still works fine.TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Smalyshev, Jonas, Aklapper, Esc3300, PokestarFan
Jonas added a comment.
Do you mean the dots under WITH ?
F8913256: image.png
This is the client side SPARQL validation which is complaining about named subqueries which are not part of the spec, but supported by Blazegraph.
Maybe they will eventually add this to the parsing engine of SPARQL.js
If
Esc3300 added a comment.
this
It would be good to have a way to de-activate this.TASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Smalyshev, Jonas, Aklapper, Esc3300, PokestarFan, GoranSMilovanovic
Esc3300 added a comment.
+ strings starting with a single quoteTASK DETAILhttps://phabricator.wikimedia.org/T171935EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Esc3300Cc: Aklapper, Esc3300, PokestarFan, GoranSMilovanovic, QZanden, EBjune, merbst, Avner, deb
17 matches
Mail list logo
