gerritbot added a comment.
Change 448160 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiComparePages: Update for MCR
https://gerrit.wikimedia.org/r/448160TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL
gerritbot added a comment.
Change 448160 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiComparePages: Update for MCR
https://gerrit.wikimedia.org/r/448160TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL
gerritbot added a comment.
Change 430483 merged by jenkins-bot:
[mediawiki/core@master] API: Introduce "templated parameters"
https://gerrit.wikimedia.org/r/430483TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL
gerritbot added a comment.
Change 430483 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] API: Introduce "templated parameters"
https://gerrit.wikimedia.org/r/430483TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL
Anomie added a comment.
That name could work.TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: gerritbot, Aklapper, daniel, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007,
daniel added a comment.
"prepareContentForDisplay", then?TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: gerritbot, Aklapper, daniel, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF,
Anomie added a comment.
In T174032#3992704, @daniel wrote:
So, let me re-phrase: the mechanism for combining output of multiple slots (whatever that mechanism may be) should be the same in EditPage, ApiParse, and prepareContentForEdit. Perhaps we want prepareContentForPreview? Something like
daniel added a comment.
In T174032#3990712, @Anomie wrote:
If the only change is that we get a content handler per slot and pass the slot role when creating each DifferenceEngine, that's fine, but it's still a change in the signature of ContentHandler::createDifferenceEngine() and
Anomie added a comment.
For ApiComparePages, ApiEditPage, ApiStashEdit, and ApiParse, I need to figure out how exactly the API should accept being passed data for multiple slots to replace the existing text parameters. This will probably take the form of parameter-templates that turn into
Anomie added a comment.
In T174032#3990611, @daniel wrote:
In T174032#3990566, @Anomie wrote:
What does matter is what changes if any get made in DifferenceEngine.
I don't expect any, since DifferenceEngine is per content model. You'd just have one DifferenceEngine for each slot.
Something
daniel added a comment.
In T174032#3990355, @Anomie wrote:
For ApiComparePages, we need to first figure out T174036: Allow the diffs to show multiple slots [MCR].
Diffs will be slot-by-slot. For T174036 we need to figure out how in what order they should be shown, with what headings, where the
daniel added a comment.
In T174032#3990566, @Anomie wrote:
What does matter is what changes if any get made in DifferenceEngine.
I don't expect any, since DifferenceEngine is per content model. You'd just have one DifferenceEngine for each slot.
ApiParse has several modes, and MCR only matters
Anomie added a comment.
In T174032#3990487, @daniel wrote:
In T174032#3990355, @Anomie wrote:
For ApiComparePages, we need to first figure out T174036: Allow the diffs to show multiple slots [MCR].
Diffs will be slot-by-slot. For T174036 we need to figure out how in what order they should be
gerritbot added a comment.
Change 413223 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] API: Update query modules for MCR
https://gerrit.wikimedia.org/r/413223TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL
14 matches
Mail list logo
