[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
WMDE-leszek added a comment. @Smalyshev this is not the priority right now. We'll try some other approach for ArticlePlaceholder later in Fall. For Lua we'd also be thinking options. So this remains stalled. We'll get back to you guys, if we decide to pursue with Elastic search. But this not going to happen in the next weeks certainly.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Lucie, dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a comment. I am not sure how looking up properties by label is different from looking up items by label. Am I missing something here? Are only properties but not items allowed to be looked up by label? I feel like I am missing some context here.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
daniel added a comment. This ticket conflates tow very different things, which makes it difficult to discuss tradeoffs: #1 looking up properties by label (PropertyIdResolver) #2 interactively searching for items based on some search input For #1 performance is an issue, and API calls are a no-go, since they would have to happen during parsing, and we may be doing dozens or even hundreds of them per page. For #2, API calls would be fine, we have much more time, and only ever one search per request. The two use cases also need very different search profiles. I suggest to discuss them in separate tickets.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
dcausse added a comment. Does it mean that we would make WikbaseClient dependent on CirrusSearch and create all necessary query builders into this client? Have we considered the possibility to run an actual API call to wbsearchentit...@wikidata.org? I have no clue if the current API output would allow to rebuild TermSearchResult nor if there are perf considerations that make this solution impossible.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dcausseCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a comment. So I thought about it a bit more and looks like we don't really need to bring search configs from repo - we can have a set of fixed config that are enough for simple straightforward match on client, and have them baked into client, and use that instead of repo ones.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a comment. @hoo I am still not sure what would be a good way to get search configs to the client... Maybe extension to cirrus-config-dump API is needed. It is also confounded by the fact that Cirrus and Wikibase use different configs (which feed from the same globals, normally, but they do not cooperate in any way AFAIK) which makes it kind of hard to inject stuff. How urgent is this? If it's important near term, I can allocate specific time to work on it closely and find solution, otherwise I'll think about it and get to it a bit later.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
hoo added a comment. @Smalyshev What's the status here? Say we want to get rid of the wb_terms table…TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
dcausse added a comment. This is in theory possible but the problem is that some profiles refer to some class implementations that are maybe not available on the host wiki. So yes we could use the sister search logic with some adaptation but the may blocker will be that the builder implementation won't be available if the wikibase extension is not loaded on the host wiki. We will have similar problems with SDoC search sooner or later since search on commons is available from all wikis. If SDoC search provides some custom implementations the code will have to be available on the host wiki. In short, if the WikibaseClient imports the builder classes then it's probably fine, if not I think it'll be hard to do it.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dcausseCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a comment. One possible way may be to use cirrus-config-dump API. But it's kinda heavyweight... OTOH, cross-wiki search uses it so maybe it's ok.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a comment. Problematic part here seems to be that WikibaseClient has separate configuration from WikibaseRepo, so we can not access search profiles, and without those we can't run the search. Not sure what is the right way to handle it.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, cmadeo, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
