[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-25 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Is there an example already somewhere?TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: Lydia_Pintscher, gerritbot,

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-24 Thread gerritbot
gerritbot added a comment. Change 427901 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add “single best value” constraint type https://gerrit.wikimedia.org/r/427901TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-20 Thread gerritbot
gerritbot added a comment. Change 427901 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add “single best value” constraint type https://gerrit.wikimedia.org/r/427901TASK

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-20 Thread gerritbot
gerritbot added a comment. Change 427675 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add $groupingMode to Context::getSnakGroup() https://gerrit.wikimedia.org/r/427675TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Let’s go with the “new constraint type” implementation for now, WikiProject seems to be slightly in favor of it and I also prefer it.TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-19 Thread gerritbot
gerritbot added a comment. Change 427675 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add $groupingMode to Context::getSnakGroup() https://gerrit.wikimedia.org/r/427675TASK

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. In the meantime, I’ll start preparing for this, because the internal challenges of implementing such a counting mode are independent of how it’s modeled as a constraint statement. (As far as I can tell, this pretty much kills the current getSnakGroup

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I contacted the WikiProject about this: https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_property_constraintsTASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-17 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. For now, I would suggest the constraint parameter (property) name “counting mode”, with values “non-deprecated statements” (default) and “best-rank statements”. But that’s up for discussion :) Hm, alternative suggestion: new constraint type “single best

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-17 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I think there are enough properties where the current interpretation (disallow multiple non-deprecated statements even if only one of them has best rank) is the preferable one: for example fictional analog of, retrieved, version type, list of episodes,

[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint

2018-04-06 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Before making this configurable, we should first investigate whether there are any “single value” constraints where the current interpretation (non-deprecated statements) is really necessary, or whether “best-rank statements” should be used everywhere.TASK