[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
Lydia_Pintscher added a comment. Is there an example already somewhere?TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
gerritbot added a comment. Change 427901 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add “single best value” constraint type https://gerrit.wikimedia.org/r/427901TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
gerritbot added a comment. Change 427901 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add “single best value” constraint type https://gerrit.wikimedia.org/r/427901TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
gerritbot added a comment. Change 427675 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add $groupingMode to Context::getSnakGroup() https://gerrit.wikimedia.org/r/427675TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
Lucas_Werkmeister_WMDE added a comment. Let’s go with the “new constraint type” implementation for now, WikiProject seems to be slightly in favor of it and I also prefer it.TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
gerritbot added a comment. Change 427675 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add $groupingMode to Context::getSnakGroup() https://gerrit.wikimedia.org/r/427675TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
Lucas_Werkmeister_WMDE added a comment. In the meantime, I’ll start preparing for this, because the internal challenges of implementing such a counting mode are independent of how it’s modeled as a constraint statement. (As far as I can tell, this pretty much kills the current getSnakGroup abstraction, since now the composition of the “snak group” varies…)TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
Lucas_Werkmeister_WMDE added a comment. I contacted the WikiProject about this: https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_property_constraintsTASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
Lucas_Werkmeister_WMDE added a comment. For now, I would suggest the constraint parameter (property) name “counting mode”, with values “non-deprecated statements” (default) and “best-rank statements”. But that’s up for discussion :) Hm, alternative suggestion: new constraint type “single best value”. WDYT?TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
Lucas_Werkmeister_WMDE added a comment. I think there are enough properties where the current interpretation (disallow multiple non-deprecated statements even if only one of them has best rank) is the preferable one: for example fictional analog of, retrieved, version type, list of episodes, domain, codomain, blood type, face value, and most external identifiers.TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183268: Add option to only consider best-rank statements when checking “single value” constraint
Lucas_Werkmeister_WMDE added a comment. Before making this configurable, we should first investigate whether there are any “single value” constraints where the current interpretation (non-deprecated statements) is really necessary, or whether “best-rank statements” should be used everywhere.TASK DETAILhttps://phabricator.wikimedia.org/T183268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, lisong, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs