[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
gerritbot added a comment. Change 417987 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add icons before statuses on special page https://gerrit.wikimedia.org/r/417987TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
gerritbot added a comment. Change 415882 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Reorganize Special:ConstraintReport https://gerrit.wikimedia.org/r/415882TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Lucas_Werkmeister_WMDE added a comment. Decision: keep the message, and show “exception” results on the special page as well.TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Lucas_Werkmeister_WMDE added a comment. I just noticed that “exception” results also have a message (“This entity is a known exception for this constraint and has been marked as such.”). I’m not sure what to do with this message – do we want to keep it? Or should we perhaps just remove it? Do we want to show these results on the special results or not?TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
gerritbot added a comment. Change 417987 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add icons before statuses on special page https://gerrit.wikimedia.org/r/417987TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Jan_Dittrich added a comment. Yes, go ahead!TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Lucas_Werkmeister_WMDE added a comment. Okay, that would look like this: F14755541: Screenshot-2018-3-8 Constraint report - wiki1.png The way the code is currently arranged, there’s also an icon in front of some (but not all) of the statuses in the summary line (“[icon] bad parameters: 2, [icon] warning: 7, compliance: 7”). Do you think that’s good or not?TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Jan_Dittrich added a comment. Would you add the icons to the “status” column (after the text) or replace the text? Adding them in front of the text: [ICON] Statustext TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Lucas_Werkmeister_WMDE added a comment. Hm, very good point. We do have different icons for warning, violation, and bad-parameters, and I think those are the only statuses that would be shown in the new version of the table. Would you add the icons to the “status” column (after the text) or replace the text?TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Jan_Dittrich added a comment. If the things in "status" are the same we signify with the icons in the item-UI, we should reuse the icons here, too, to make them easier to learn and give people who learned them already the benefit of using their knowledge.TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Jan_Dittrich added a comment. From looking at at (and there might be things I don't understand/misinterpret) the new version also looks better to me, design wise.TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Lucas_Werkmeister_WMDE added a comment. Note: The old task T188728: Replace claim with violation message in Special:ConstraintReport is also related.TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
Lucas_Werkmeister_WMDE added a comment. The above change implements this (and that’s what I used for the “proposed change” screenshot too). #WMDE-Design – if you want, I can put it on wikidata-lexeme.wmflabs.org so you can try it out yourself. (Or just come to my desk :) )TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188728: Replace claim with violation message in Special:ConstraintReport
gerritbot added a comment. Change 415882 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Reorganize Special:ConstraintReport https://gerrit.wikimedia.org/r/415882TASK DETAILhttps://phabricator.wikimedia.org/T188728EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Lucas_Werkmeister_WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, JGirault, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
