[Wikidata-bugs] [Maniphest] [Commented On] T189808: Make action=undo work with multiple slots.

2018-07-12 Thread daniel
daniel added a comment.
an "undo without edit" could have all fields' content as  or as data stored in the session server-side.

No need for even that, all data is already stored on the server side.TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Tgr, CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189808: Make action=undo work with multiple slots.

2018-07-12 Thread Anomie
Anomie added a comment.
I note there's no reason the edit form with the undo content would have to actually be editable for any particular field or having the raw content of that field being displayed to the user, as long as the preview and show changes functions work sensibly. In the extreme case, an "undo without edit" could have all fields' content as  or as data stored in the session server-side.TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: Tgr, CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189808: Make action=undo work with multiple slots.

2018-07-12 Thread daniel
daniel added a comment.
maybe we need undo-without-edit anyway if some slots don't support editing but support undo?

Yes. This is already the case for SDC. MediaInfo does not support direct editing.TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Tgr, CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T189808: Make action=undo work with multiple slots.

2018-07-12 Thread Tgr
Tgr added a comment.
When you are undoing past edits (ie. the "new" end of the undo range is not the current edit), the undo operation creates a content (array of contents, post-MCR) that does not exist on disk. That content needs to be presented to the user and then saved. Currently, EditPage just displays that content in the edit form; adding support for undo-without-edit would be nontrivial work, while multi-slot editing gives you multi-slot undo for free. (OTOH maybe we need undo-without-edit anyway if some slots don't support editing but support undo?)TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TgrCc: Tgr, CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profil, Smalyshev, TomT0m, Liuxinyu970226, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, JJMC89, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs