[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
Jakob_WMDE added a comment. @Lydia_Pintscher https://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L587=""> created, added F1 cleared added form -> assigned id is F2 TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Lydia_Pintscher, gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
Lydia_Pintscher added a comment. Can we have an example link/edit? Thanks! :)TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Lydia_PintscherCc: Lydia_Pintscher, gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 430386 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Test that using clear with wbeditentity does not reset nextFormId for lexemes https://gerrit.wikimedia.org/r/430386TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 429792 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Let entities clear themselves https://gerrit.wikimedia.org/r/429792TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 430372 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Implement ClearableEntity for Form and Lexeme https://gerrit.wikimedia.org/r/430372TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 430327 merged by jenkins-bot: [mediawiki/vendor@master] Update wikibase/data-model to 7.5.0 https://gerrit.wikimedia.org/r/430327TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 430386 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/WikibaseLexeme@master] Test that using clear with wbeditentity does not reset nextFormId for lexemes https://gerrit.wikimedia.org/r/430386TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 430372 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/WikibaseLexeme@master] Implement ClearableEntity for Form and Lexeme https://gerrit.wikimedia.org/r/430372TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 430327 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/vendor@master] Update wikibase/data-model to 7.4.0 https://gerrit.wikimedia.org/r/430327TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
Addshore added a comment. In T192264#4168396, @Jakob_WMDE wrote: PR on GitHub: https://github.com/wmde/WikibaseDataModel/pull/776 PR merged, and 7.4.0 of DataModel released.TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, AddshoreCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
Jakob_WMDE added a comment. PR on GitHub: https://github.com/wmde/WikibaseDataModel/pull/776TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
gerritbot added a comment. Change 429792 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] [DNM] Let entities clear themselves https://gerrit.wikimedia.org/r/429792TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T192264: Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
Addshore added a comment. It might make sense for EntityDocument to have a clear() method in the interface. Then in EditEntity::clearEntity instead of creating a new Entity you could create a copy() and call clear() which would have special handling for Lexeme (and also special handling for Property, which is currently hard coded in EditEntity)TASK DETAILhttps://phabricator.wikimedia.org/T192264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Jakob_WMDE, Addshore, Aklapper, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
