gerritbot added a comment.
Change 431575 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add separators parameter to Context::getSnakGroup()
https://gerrit.wikimedia.org/r/431575TASK DETAILhttps://phabricator.wikimedia.org/T193634EMAIL
gerritbot added a comment.
Change 431575 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add separators parameter to Context::getSnakGroup()
https://gerrit.wikimedia.org/r/431575TASK
Lucas_Werkmeister_WMDE added a comment.
Well, wait a second. Not only do the checkers not need the separating snaks… I don’t think they really need the other snak groups (other than the one that the current snak is in) either. So really – do we need to change the return type at all? Can’t we just
Lucas_Werkmeister_WMDE added a comment.
Okay, I think the new interface could be:
getSnakGroup is renamed to getSnakGroups.
It gains an additional parameter, a list of property IDs (possibly empty): the separators.
It returns not a list of snaks, but a list of SnakGroup objects. SnakGroup is a
