[Wikidata-bugs] [Maniphest] [Commented On] T194770: [Bug] False positive error in detecting same label-description in Wikidata
gerritbot added a comment. Change 447384 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Select description in appropriate language during label-description conflict check https://gerrit.wikimedia.org/r/447384TASK DETAILhttps://phabricator.wikimedia.org/T194770EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, gerritbotCc: gerritbot, matej_suchanek, daniel, johl, Giku, PokestarFan, Aklapper, Mbch331, Laddo, Jklamo, Lea_Lacroix_WMDE, Nikki, Lucas_Werkmeister_WMDE, Ladsgroup, Lydia_Pintscher, VIGNERON, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194770: [Bug] False positive error in detecting same label-description in Wikidata
daniel added a comment. In T194770#651, @matej_suchanek wrote: This is certainly the cause. @daniel, is it possible that it was dropped intentionally in rEWBAa872ae062070c0d415cafd62dc08269319498fae? Not intentionally, no. Looks like a bug. As far as I can tell from briefly looking at the code, the problem is in TermSqlIndex::getLabelWithDescriptionConflicts: $matchConditions = [ 'L.term_language' => $lang, ]; should instead be $matchConditions = [ 'L.term_language' => $lang, 'D.term_language' => $lang, ]; Note that this will very likely change the query plan and may change query performance significantly. In theory, it should make performance better, but this is definitely something to keep an eye on.TASK DETAILhttps://phabricator.wikimedia.org/T194770EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, danielCc: gerritbot, matej_suchanek, daniel, johl, Giku, PokestarFan, Aklapper, Mbch331, Laddo, Jklamo, Lea_Lacroix_WMDE, Nikki, Lucas_Werkmeister_WMDE, Ladsgroup, Lydia_Pintscher, VIGNERON, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194770: [Bug] False positive error in detecting same label-description in Wikidata
gerritbot added a comment. Change 447384 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [mediawiki/extensions/Wikibase@master] Select description in appropriate language during label-description conflict check https://gerrit.wikimedia.org/r/447384TASK DETAILhttps://phabricator.wikimedia.org/T194770EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, gerritbotCc: gerritbot, matej_suchanek, daniel, johl, Giku, PokestarFan, Aklapper, Mbch331, Laddo, Jklamo, Lea_Lacroix_WMDE, Nikki, Lucas_Werkmeister_WMDE, Ladsgroup, Lydia_Pintscher, VIGNERON, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194770: [Bug} False positive error in detecting same label-description in Wikidata
Lucas_Werkmeister_WMDE added a comment. It looks like this happens when the target item has the same description in a different language (Q489675 is described as just “film” in Albanian) – I was able to reproduce this on testwikidata with Q160805 and Q160806. Is this actually a change in behavior? I don’t know what the previous code did.TASK DETAILhttps://phabricator.wikimedia.org/T194770EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ladsgroup, Lydia_Pintscher, VIGNERON, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194770: [Bug} False positive error in detecting same label-description in Wikidata
Ladsgroup added a comment. We actually made it more strict so this should not happen, I will check this ASAPTASK DETAILhttps://phabricator.wikimedia.org/T194770EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, VIGNERON, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
