[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-07-09 Thread gerritbot 
gerritbot added a comment.
Change 443104 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make EntityReferenceExtractors configurable per entity type

https://gerrit.wikimedia.org/r/443104TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-07-03 Thread gerritbot 
gerritbot added a comment.
Change 443451 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Clean up around EntityParserOutputDataUpdater related code

https://gerrit.wikimedia.org/r/443451TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-07-02 Thread gerritbot 
gerritbot added a comment.
Change 443451 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Clean up around EntityParserOutputDataUpdater related code

https://gerrit.wikimedia.org/r/443451TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-07-02 Thread gerritbot 
gerritbot added a comment.
Change 442864 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Refactor ParserOutputDataUpdater

https://gerrit.wikimedia.org/r/442864TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Pablo-WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-06-29 Thread gerritbot 
gerritbot added a comment.
Change 443104 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Make EntityReferenceExtractors configurable per entity type

https://gerrit.wikimedia.org/r/443104TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Pablo-WMDE, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-06-28 Thread gerritbot 
gerritbot added a comment.
Change 442864 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Refactor ParserOutputDataUpdater

https://gerrit.wikimedia.org/r/442864TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Jakob_WMDE, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-06-28 Thread Jakob_WMDE 
Jakob_WMDE added a comment.
More concrete plan:


rename EntityParserOutputDataUpdater to EntityParserOutputDataUpdaterCollection (naming suggestions welcome)
it should only be used to register EntityParserOutputDataUpdaters, pass them the entity they should operate on, and call updateParserOutput on them
processStatements and processSitelinks should go into concrete EntityParserOutputDataUpdater implementations




make EntityParserOutputDataUpdater an interface that operates on entities and updates the ParserOutput
has methods processEntity and updateParserOutput




existing StatementDataUpdaters should either be changed to implement EntityParserOutputDataUpdater instead, or they need an adapter (is that better?)
note: this is worse performance-wise. Instead of iterating over all statements once and passing individual statements to StatementDataUpdaters we would need to iterate over all statements once per StatementDataUpdater
everything concerning SiteLinks and Statements is removed from ReferencedEntitiesDataUpdater - it should only deal with EntityIds and add their respective links to ParserOutput
ReferencedEntitiesDataUpdater gets a per entity type collection of EntityIdCollectors (naming suggestions welcome) injected
the SiteLink bit of it becomes a SiteLinkBadgeItemIdCollector
the Statement bit becomes StatementReferencedEntityIdCollector


TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Jakob_WMDE, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198295: Make EntityParserOutputDataUpdater configurable

2018-06-27 Thread Jakob_WMDE 
Jakob_WMDE added a comment.
Random notes from an initial investigation


EntityParserOutputDataUpdater should probably not know about StatementDataUpdater and SiteLinkDataUpdater.
ReferencedEntitiesDataUpdater
split into 3 classes: one actual ReferencedEntitiesDataUpdater, one service that collects entity ids from statements, one service that collects entity ids from sitelink badges
could either take a list of entity ids from per-entity type collector classes, or take a per-entity service that takes the entity and scrapes its entity ids

TASK DETAILhttps://phabricator.wikimedia.org/T198295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: Jakob_WMDE, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs