[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-12-03T12:14:25Z] Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:476267| Don’t send SPARQL prefixes in WikibaseQualityConstraints (T204317)]] (duration: 00m 49s)TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, StashbotCc: Stashbot, Ladsgroup, Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 476267 merged by jenkins-bot: [operations/mediawiki-config@master] Don’t send SPARQL prefixes in WikibaseQualityConstraints https://gerrit.wikimedia.org/r/476267TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Ladsgroup, Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 476267 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Don’t send SPARQL prefixes in WikibaseQualityConstraints https://gerrit.wikimedia.org/r/476267TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Ladsgroup, Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
Ladsgroup added a comment. One note: There is no train this week.TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, LadsgroupCc: Ladsgroup, Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 473529 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add option to control SPARQL server compatibility https://gerrit.wikimedia.org/r/473529TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 473057 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Remove wikibase-beta prefix from SparqlHelper https://gerrit.wikimedia.org/r/473057TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 473529 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add option to control SPARQL server compatibility https://gerrit.wikimedia.org/r/473529TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
Lucas_Werkmeister_WMDE added a comment. Let’s go with the first option, but only with a single config flag. I’ll implement this now.TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
Lucas_Werkmeister_WMDE added a comment. Okay, I5c98bb3dd9 gets rid of wikibase-beta, which simplifies things a bit. After that, I think we have two options: Introduce a flag whether the query service has the default prefixes built-in, and skip them if that flag is set to true. To stay on the safe side, it should probably default to false, so we’d also need a production config change to set it to true there. Just assume the query service has the default prefixes built-in, and no user will ever use a different SPARQL server. I would prefer the first option, but just today I realized that we’re currently acting more like the second option: for “has type” queries, we include query hints without even specifying the hint: prefixes, which is completely broken on non-BlazeGraph servers. So if we want to go for the first option, there should probably also be a “supports query hints” flag (or it could be merged with “supports default prefixes” into “is a Wikibase RDF Query server”).TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 473057 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Remove wikibase-beta prefix from SparqlHelper https://gerrit.wikimedia.org/r/473057TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
Addshore added a comment. I believe the patches in T112127 are now all merged @Lucas_Werkmeister_WMDE ?TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, AddshoreCc: Addshore, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 471725 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t send SPARQL prefixes for REGEX queries https://gerrit.wikimedia.org/r/471725TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
gerritbot added a comment. Change 471725 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t send SPARQL prefixes for REGEX queries https://gerrit.wikimedia.org/r/471725TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries
Smalyshev added a comment. A simple solution, I suppose, would be to completely skip prefixes for REGEX queries, which are (I believe) the most common queries we send out and never need any prefixes. This looks like a good start.TASK DETAILhttps://phabricator.wikimedia.org/T204317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Lahi, Gq86, GoranSMilovanovic, QZanden, merbst, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs