[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[gerritbot]

gerritbot added a comment.


  Change 518713 abandoned by Lucas Werkmeister (WMDE):
  bridge: only count data bridge-enabled links
  
  Reason:
  very outdated
  
  https://gerrit.wikimedia.org/r/518713

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dr0ptp4kt, Charlie_WMDE, Lucas_Werkmeister_WMDE, Esc3300, Michael, 
Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I’ve updated the documentation draft 

 with some of the new decisions we made, but we’ll need to know more about the 
possible edit flows before we can finalize it.

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Charlie_WMDE, Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, 
Aklapper, Lydia_Pintscher, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T224832#5292441 , 
@Michael wrote:
  
  > I think we should require the `.data-bridge-enabled` **either** on a parent 
tag **or** a child tag, **not both**. Allowing it on both would be too 
confusing and I think it makes sense here to follow Python's Zen: `There should 
be one-- and preferably only one --obvious way to do it.`
  
  
  That seems right.
  
  > I would favor requiring the class on the parent ``. This would allow us 
to work even on somewhat buggy fields, like the `Mounting` field in the infobox 
of South Pole Telescope , 
which has two edit links for a single value.
  > 
  > However, I think this is in part also an UX/product issue as the template 
editors are also our users. @Lydia_Pintscher, @Charlie_WMDE what do you think?
  
  I am not sure I fully understand the issue yet so let's sit together and go 
over it.
  
  > Also, I still haven't been able to create a simple wikidata-template 
locally. Should we create an example implementation for both options to be 
better at deciding this?
  
  I think that'd be super useful.

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Lydia_Pintscher
Cc: Charlie_WMDE, Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, 
Aklapper, Lydia_Pintscher, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  So I think we can require `.data-bridge-enabled` on some descendant of the 
``, such as the `` (easy to implement in wikitext, probably slightly 
annoying to implement for us); on some parent of the ``, such as a 
``/`` or a `` (probably slightly annoying to implement in 
wikitext, easy to implement for us); or both (maximum flexibility for wikitext 
authors, probably somewhat annoying to implement for us).
  
  We could also continue to allow `.data-bridge-enabled` on the `` itself, 
but if it’s not possible to generate such links in MediaWiki I don’t really see 
the point unless we get it for free (which I don’t think is likely – there’s no 
CSS selector for “class on this element or a child/descendant” as far as I 
know).

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, Superyetkin, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I think I’ve discovered a problem while preparing an example on the 
documentation draft 
.
 Currently, enwiki’s Module:WikidataIB 
 `createicon` function uses 
plain image links to create the icon, with something like this:
  
[[File:OOjs UI icon 
edit-ltr-progressive.svg|…|link=https://www.wikidata.org/wiki/Q2013?uselang=en#P856]]
  
  (I assume other wikis’ infobox modules work similarly, but I didn’t check.) 
You can add a `|class=data-bridge-enabled` parameter to that, but this results 
in the `class` being added to the //`` element//, not the surrounding 
`` element. So if we search for `a.data-bridge-enabled` we won’t find it.
  
  In fact, MediaWiki has no built in way to add link attributes 
, so we can’t require the 
`class="data-bridge-enabled"` on the `` element directly, as far as I 
understand.

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, Superyetkin, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[gerritbot]

gerritbot added a comment.


  Change 518713 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] bridge: only count data bridge-enabled 
links
  
  https://gerrit.wikimedia.org/r/518713

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Michael]

Michael added a comment.


  In T224832#5278274 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I was bold  and updated 
 the page, renaming the 
link class to `data-bridge-enabled` and adding a wrapper class of 
`data-bridge-capable`, because I want to upload a Gerrit change (edit: this 
Gerrit change ) that applies these 
requirements to the current link counter. Of course, we can still discuss and 
change them.
  
  
  

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I was bold  and updated 
 the page, renaming the 
link class to `data-bridge-enabled` and adding a wrapper class of 
`data-bridge-capable`, because I want to upload a Gerrit change that applies 
these requirements to the current link counter. Of course, we can still discuss 
and change them.

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > Is the class name fine?
  
  It should probably be `databridge-enabled` rather than 
`wikidatabridge-enabled`, unless we want to make the class name configurable. 
(And I think elsewhere we’re hyphenating “data bridge”, so perhaps 
`data-bridge-enabled` too.)

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lea_Lacroix_WMDE]

Lea_Lacroix_WMDE added a comment.


  @Michael Yes, for now I'll add a "documentation draft" section in 
"development" and later, when we have a product ready, I'll create a proper 
"documentation" section.

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > Do we want to get our data from the href or data-attributes? (I like href, 
because then we can ensure correct no-js behaviour. But they cannot edit this 
without js on wikidata.org either...)
  
  A working link is also useful for middle-clicking (open in new tab).
  
  > Do we want to enable this based on a class on the link or differently? Is 
the class name fine?
  
  I would suggest a class on the link //and// a class on some surrounding 
element (e. g. the whole infobox table). I think on many wikis the link is 
generated in one place (e. g. enwiki’s Module:WikidataIB 
 `createicon` function), and 
requiring the class on a surrounding element allows the editors to add the 
class in that one place while still enabling/disabling the Wikidata Bridge 
integration per infobox (type).
  
  > [The edit link] has to link to the respective property of that item on 
Wikidata
  
  What if the link points to a specific statement, e. g. 
https://www.wikidata.org/wiki/Q1#Q1$a5887543-4c91-e37d-712f-9362af351f80? Do we 
want to support that? (I don’t know if any templates currently do this.)

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224832: Connect template parameter to corresponding Wikidata property

[Esc3300]

Esc3300 added a comment.


  For harvesttemplates, it would be great if this could be queried/defined 
somewhere

TASK DETAIL
  https://phabricator.wikimedia.org/T224832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Esc3300
Cc: Esc3300, Michael, Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs