[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-29 Thread alaa_wmde
alaa_wmde added a comment. double checked on beta. https://wikidata.beta.wmflabs.org/wiki/Lexeme:L3448 -> https://wikidata.beta.wmflabs.org/wiki/Lexeme:L3451 -> https://wikidata.beta.wmflabs.org/wiki/Lexeme:L3452 visiting what links here on L3451 (the double-redirect) or the

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-29 Thread Znotch190711
Znotch190711 added a comment. Whoa! A bug? On Wikidata? Oh shoot! TASK DETAIL https://phabricator.wikimedia.org/T228996 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Znotch190711 Cc: Znotch190711, Michael, LucasWerkmeister,

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-27 Thread gerritbot
gerritbot added a comment. Change 525855 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Avoid fataling on double-redirects when formatting Lexeme links. https://gerrit.wikimedia.org/r/525855 TASK DETAIL https://phabricator.wikimedia.org/T228996 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-26 Thread alaa_wmde
alaa_wmde added a comment. In T228996#5369507 , @gerritbot wrote: > Change 525855 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): > [mediawiki/extensions/WikibaseLexeme@master] Avoid fataling on

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-26 Thread gerritbot
gerritbot added a comment. Change 525855 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/WikibaseLexeme@master] Avoid fataling on double-redirects when formatting Lexeme links. https://gerrit.wikimedia.org/r/525855 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-25 Thread alaa_wmde
alaa_wmde added a comment. It is a bit funny how it works on Wikibase right now. - I created three items Q534840 Q534841 and Q534842 - I redirected Q534840 to Q534841 - I redirected Q534841 to Q534842 - now when I visit Q534840 I get redirected to Q534841 with an earlier revision

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-25 Thread alaa_wmde
alaa_wmde added a comment. In T228996#5365525 , @LucasWerkmeister wrote: > I don’t think Wikibase should follow the double redirect – that would go against longstanding

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace due to double-redirect

2019-07-25 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. In T228996#5365525 , @LucasWerkmeister wrote: > I don’t think Wikibase should follow the double redirect – that would go against longstanding

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace

2019-07-25 Thread Ladsgroup
Ladsgroup added a comment. In T228996#5365464 , @alaa_wmde wrote: > I think handling redirect chains makes sens conceptually, unless technicallly there's a blocker the only thing is that we definitely need to have a way to find

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace

2019-07-25 Thread alaa_wmde
alaa_wmde added a comment. I think handling redirect chains makes sens conceptually, unless technicallly there's a blocker TASK DETAIL https://phabricator.wikimedia.org/T228996 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace

2019-07-25 Thread alaa_wmde
alaa_wmde added a comment. Nice catch. What's the solution? handling redirection chains (caution to account for possible cyclic-chain)? or something else like stopping at first redirect (whatever that means) regardless whether it is another redirect or not? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace

2019-07-25 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Lovely :P Thanks for figuring that out. TASK DETAIL https://phabricator.wikimedia.org/T228996 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Ladsgroup, Alicia_Fagerving_WMSE,

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace

2019-07-25 Thread Ladsgroup
Ladsgroup added a comment. It's basically because of a double redirect: L44373 ->L44168 -> L44166 RedirectResolvingEntityLookup doesn't handle double redirects, causing everything to explode majestically. TASK DETAIL https://phabricator.wikimedia.org/T228996 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace

2019-07-25 Thread Ladsgroup
Ladsgroup added a comment. Another way to reproduce this error: https://www.wikidata.org/wiki/Special:WhatLinksHere/Lexeme:L44168 F29869329: image.png TASK DETAIL https://phabricator.wikimedia.org/T228996 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T228996: Internal error in Recent Changes for Lexeme namespace

2019-07-25 Thread Ladsgroup
Ladsgroup added a comment. Logstash output: #0 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Wikibase/lib/includes/Store/DispatchingEntityRevisionLookup.php(59): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\Lexeme\Domain\Model\LexemeId, integer,