[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 571964 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Wrap PrefetchingPropertyTermLookup cache to emit metrics https://gerrit.wikimedia.org/r/571964 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

Ladsgroup added a comment. This: https://grafana.wikimedia.org/d/00548/wikibase-wb_terms?orgId=1=1581517070153=1581560270153=6 F31614497: image.png TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 571964 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Wrap PrefetchingPropertyTermLookup cache to emit metrics https://gerrit.wikimedia.org/r/571964 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 569210 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Wire up caching around PrefetchingPropertyTermLookup https://gerrit.wikimedia.org/r/569210 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 568494 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] LatestRevisionAndRedirectResolverTest: avoid repeated lookups https://gerrit.wikimedia.org/r/568494 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 567487 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add CachingPrefetchingTermLookup https://gerrit.wikimedia.org/r/567487 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 567020 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add RedirectResolvingLatestRevisionLookup https://gerrit.wikimedia.org/r/567020 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 569210 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Wire up caching around PrefetchingPropertyTermLookup https://gerrit.wikimedia.org/r/569210 TASK DETAIL https://phabricator.wikimedia.org/T242871

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 568494 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] LatestRevisionAndRedirectResolverTest: avoid repeated lookups https://gerrit.wikimedia.org/r/568494 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 566779 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add TermCacheKeyBuilder https://gerrit.wikimedia.org/r/566779 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 567487 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Add CachingPrefetchingTermLookup https://gerrit.wikimedia.org/r/567487 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 567020 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Add LatestRevisionResolvingTermCache https://gerrit.wikimedia.org/r/567020 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

gerritbot added a comment. Change 566779 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Add TermCache https://gerrit.wikimedia.org/r/566779 TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

Addshore added a comment. We dove a bit deeper into all of the things that are happening surrounding the prefetching, term buffers, lookups, fallbacks and caching and decided that to do this properly we should probably aim for something like this: F31521047: image.png

[Wikidata-bugs] [Maniphest] [Commented On] T242871: wbterms: Add a cache for PrefetchingPropertyTermLookup::prefetchTerms()

Ladsgroup added a comment. It should use the formatter cache. TASK DETAIL https://phabricator.wikimedia.org/T242871 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, WMDE-leszek, Jakob_WMDE, Addshore, Ladsgroup, Iflorez,