[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Krinkle added a comment. The uselang is a red herring. Yes it can be strange, but that is supported . It is possible that there is a bug and that this value should be discarded, but that is not the bug for this task. Our BagOStuff

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Krinkle added a comment. In T247466#5964879 , @gerritbot wrote: > Change 579302 **merged** by jenkins-bot: > [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in unknown languages in Lua >

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

brennen added a comment. Given pre-existing nature of this breakage and per conversation in RelEng, we'll go ahead and remove this as a train blocker. It'd still definitely be good to reduce the log noise if possible. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Ladsgroup added a comment. In T247466#5965186 , @Jdforrester-WMF wrote: > Resolved? Nope :( I reverted the backport because it doesn't fix the issue. We have been fixing the issue on `WikibaseLanguageIndependentLuaBindings` but

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Jdforrester-WMF added a comment. Resolved? TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle,

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

gerritbot added a comment. Change 579302 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in unknown languages in Lua https://gerrit.wikimedia.org/r/579302 TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

gerritbot added a comment. Change 579302 had a related patch set uploaded (by Tarrow; owner: Ladsgroup): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in unknown languages in Lua https://gerrit.wikimedia.org/r/579302 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

brennen added a comment. Thanks - and yeah, let's backport. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226,

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Tarrow added a comment. I've just merged https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/572259 which I think will stem most (maybe all?) of these errors. From my side I'd be happy for this to not block the train in either case but we could also backport this band-aid to

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Tarrow added a comment. Yes, I don't think this should be a blocker; clearly I should have done a better job of fixing this symptom earlier rather than going for the cause since it's making so many people worry TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Ladsgroup added a comment. Yup, I don't think it should be a train blocker though. The normal pageviews can't get broken, it breaks when you try to see the page in an invalid language and also it happens virtually on commons because the language they request is bound to user's language

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

Krinkle added a comment. This is a fatal error from WikibaseClient code as seen on group1 with Commons. The stack trace suggests it is encountered while parsing wikitext, which suggests to me that it is quite likely this will also start breaking Wikipedia pages views and make some pages