[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-19 Thread Krinkle 
Krinkle added a comment.


  The uselang is a red herring. Yes it can be strange, but that is supported 
. It is possible that there 
is a bug and that this value should be discarded, but that is not the bug for 
this task.
  
  Our BagOStuff class allows any character to be used in a cache key, no 
problem. It just needs to be encoded correcrty, which happens automaticaly if 
you call `makeKey()` on the correct cache object - the same object that will 
store the value. The problem is that Wikibase's SimpleCacheWithBagOStuff, 
unlike all other proxy classes, is not proxying the makeKey methods correctly.

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: hashar, Krinkle, WMDE-leszek, Ladsgroup, Tarrow, Jdforrester-WMF, 
Agusbou2015, Liuxinyu970226, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-16 Thread Krinkle 
Krinkle added a comment.


  In T247466#5964879 , 
@gerritbot wrote:
  
  > Change 579302 **merged** by jenkins-bot:
  > [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label 
in unknown languages in Lua
  > https://gerrit.wikimedia.org/r/579302
  
  This looks like it would fix the issue but I'm still seeing the same error in 
prod:
  
[fatal] CacheInvalidArgumentException:
Cache key contains characters that are not allowed: 
`Q49092_1112215108_⧼lang⧽_label`

#0 
/srv/mediawiki/php-1.35.0-wmf.23/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php(69)
… #5 
/srv/mediawiki/php-1.35.0-wmf.23/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php(60)
… #7 
/srv/mediawiki/php-1.35.0-wmf.23/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26)
… #13 /srv/mediawiki/php-1.35.0-wmf.23/includes/parser/Parser.php(3596)
… #33 
/srv/mediawiki/php-1.35.0-wmf.23/includes/poolcounter/PoolCounterWork.php(125)
… #37 /srv/mediawiki/php-1.35.0-wmf.23/includes/MediaWiki.php(519): 
ViewAction->show()
… #41 /srv/mediawiki/php-1.35.0-wmf.23/index.php(47): MediaWiki->run()

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: WMDE-leszek, Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, 
Liuxinyu970226, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread brennen 
brennen added a comment.


  Given pre-existing nature of this breakage and per conversation in RelEng, 
we'll go ahead and remove this as a train blocker.  It'd still definitely be 
good to reduce the log noise if possible.

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: brennen
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread Ladsgroup 
Ladsgroup added a comment.


  In T247466#5965186 , 
@Jdforrester-WMF wrote:
  
  > Resolved?
  
  Nope :( I reverted the backport because it doesn't fix the issue.
  
  We have been fixing the issue on `WikibaseLanguageIndependentLuaBindings` but 
it's actually happening on `WikibaseLanguageDependentLuaBindings` and 
`LanguageFallbackLabelDescriptionLookup` has the wrong language code, I have 
been trying to fix it by adding list of term languages as a dependency but the 
class is being instantiated in 22 different places (some outside of Wikibase 
git repo) making it pretty hard to fix :/ Let me find an interim fix for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread Jdforrester-WMF 
Jdforrester-WMF added a comment.


  Resolved?

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread gerritbot 
gerritbot added a comment.


  Change 579302 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in 
unknown languages in Lua
  
  https://gerrit.wikimedia.org/r/579302

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread gerritbot 
gerritbot added a comment.


  Change 579302 had a related patch set uploaded (by Tarrow; owner: Ladsgroup):
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not try to load label in 
unknown languages in Lua
  
  https://gerrit.wikimedia.org/r/579302

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread brennen 
brennen added a comment.


  Thanks - and yeah, let's backport.

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: brennen
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread Tarrow 
Tarrow added a comment.


  I've just merged 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/572259 which I 
think will stem most (maybe all?) of these errors. From my side I'd be happy 
for this to not block the train in either case but we could also backport this 
band-aid to reduce the logspam

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread Tarrow 
Tarrow added a comment.


  Yes, I don't think this should be a blocker; clearly I should have done a 
better job of fixing this symptom earlier rather than going for the cause since 
it's making so many people worry

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread Ladsgroup 
Ladsgroup added a comment.


  Yup, I don't think it should be a train blocker though. The normal pageviews 
can't get broken, it breaks when you try to see the page in an invalid language 
and also it happens virtually on commons because the language they request is 
bound to user's language (most wikis request data in their language).

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-11 Thread Krinkle 
Krinkle added a comment.


  This is a fatal error from WikibaseClient code as seen on group1 with 
Commons. The stack trace suggests it is encountered while parsing wikitext, 
which suggests to me that it is quite likely this will also start breaking 
Wikipedia pages views and make some pages unsaveable and/or onviewable.

TASK DETAIL
  https://phabricator.wikimedia.org/T247466

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs