[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-28 Thread Librarian_lena
Librarian_lena added a comment. Thanks @Jarekt, I've been trying to figure it out based on the other modules you mentioned, especially [[Module:Artwork]], but nothing works even when I copy and paste all the lines that your comments say are about harvesting Wikidata to populate the rows. I

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-27 Thread Verdy_p
Verdy_p added a comment. The effect is not the same depending on wikis. I assume they don't have the same version of Scribunto deployed. For example, if I click on the error link shown in pages having script errors in Commons, the wikitext of the linked Module opens without line numbers

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-27 Thread Jarekt
Jarekt added a comment. That is strange, my system behaves differently. After opening a Module file originally there are no number lines, but than a different skin (or something ) kicks in and I can see code lines. Also if I see an error line number that is the correct line number I see in

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-27 Thread Verdy_p
Verdy_p added a comment. @ Jarekt: I use the same method also With Notepad++ (it's strange that the source editor for modules in the wiki does not even show the line numbers!) Note that in the text console, the line numbers for errors located in the console input is always 6 lines

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-27 Thread Jarekt
Jarekt added a comment. Lena, I am happy to help, I just cant commit to do all the work as I am stretch quite thin with maintenance of existing modules. There are no instructions other than https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual and

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-26 Thread Librarian_lena
Librarian_lena added a comment. In T252259#6122296 , @Susannaanas wrote: > I have not been able to locate the code that reads and writes to Commons yet. Hello! Can anyone point to an example or some instructions for how to do

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Susannaanas
Susannaanas added a comment. Hi @mxn and welcome onboard! You might have interest in thinking how Warper control point data tables should be stored and utilized by the warping process. It will not be the first thing to do here though. TASK DETAIL https://phabricator.wikimedia.org/T252259

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Librarian_lena
Librarian_lena added a comment. In T252259#6122295 , @Susannaanas wrote: > I have worked on this page to display a bit of the FRBR division as well as mark properties that are available in the Map template

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Susannaanas
Susannaanas added a comment. I have not been able to locate the code that reads and writes to Commons yet. TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Susannaanas Cc: Chippyy, Yupik,

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Susannaanas
Susannaanas added a comment. I have worked on this page to display a bit of the FRBR division as well as mark properties that are available in the Map template https://www.wikidata.org/wiki/Wikidata:WikiProject_Maps/Historical_map_properties TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Susannaanas
Susannaanas added a comment. The Map template links to Warper via the warp status property and button. So this is the sending end skip (nothing) unwarped = {{Clickable button|target=//warper.wmflabs.org/wikimaps/new?pageid={{PAGEID}} warped = {{Clickable

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Susannaanas
Susannaanas added a comment. And here https://github.com/timwaters/mapwarper TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Susannaanas Cc: Chippyy, Yupik, Abbe98, TiagoLubiana, Jarekt,

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Susannaanas
Susannaanas added a comment. The codebase is here, need to locate the point where maps are read https://github.com/wikimaps-dev/mapwarper TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Susannaanas
Susannaanas added a comment. In T252259#6122219 , @Abbe98 wrote: > This I believe should still work. The problem would be when a map is imported to Warper because it parses and reads values from the template, values that would not be

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-10 Thread Abbe98
Abbe98 added a comment. > Workflow between Wikimaps Warper and the Map template. The Map template has a value for the warp status of the image in Wikimaps Warper. Warper writes to the Map template the changed value when it alters the map image. This I believe should still work. The

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. @Jarekt : This is what I thought might be possible. That the template is crafted so that it can still manage the text-based functions it has had previously. So maybe we can first see that we can safeguard **warp status**: If set, it will create a link to

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Jarekt
Jarekt added a comment. In T252259#6121786 , @Susannaanas wrote: > Can we make a temporary template for this module, like MapWD? I linked c:Template:Map/sandbox to the new

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Librarian_lena
Librarian_lena added a comment. @Susannaanas I'm glad you think so! This is Wikidata-to-Commons-properties proposal I did recently for a work project, although I've removed institution-specific identifiers. Is it helpful in this context? F31810347: WikidataCommonsCrosswalk.docx

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. @Librarian_lena You are providing really valuable information about the division between the work and the copy, and how this information should be shared between Wikidata and Commons. I wonder if you could even annotate the Historical map properties

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. Can we make a temporary template for this module, like MapWD? TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Susannaanas Cc: Yupik, Abbe98, TiagoLubiana, Jarekt,

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. BTW Cool ascii art! TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Susannaanas Cc: Yupik, Abbe98, TiagoLubiana, Jarekt, Aklapper, Susannaanas, Librarian_lena,

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. Thank you @Jarekt ! There will be challenges ahead as @Abbe98 mentioned, apart from unique properties. But we can work first on the properties. - Workflow between Wikimaps Warper and the Map template. The Map template has a value for the warp status of the

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Jarekt
Jarekt added a comment. I have very early stage of Module:Map done. At this stage the goal is to recreate Template:Map in Lua. Template Map has so many fields that at this point I added about 50-60% of fields which were shared with Artwork

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Librarian_lena
Librarian_lena added a comment. Hi everyone! Thank you for the attention to this and thanks for letting me pull you in, @Susannaanas and @Jarekt. To answer the question about usages, what I'm hoping for is a way to set up a workflow whereby Wikidata fields that I spend a lot of time working

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. Sounds great, @Jarekt ! TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Susannaanas Cc: Abbe98, TiagoLubiana, Jarekt, Aklapper, Susannaanas, Librarian_lena,

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Jarekt
Jarekt added a comment. In T252259#6120966 , @Susannaanas wrote: > I'm up for working with you if @Jarekt can give advise! Susanna, Stage #1 is to just reproduce the capabilities of the current template in Lua. I can get it started

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. What other usages do you envision? Also, it is not necessary to complete it here and now, but to set it on a trajectory that will keep it up-to-date. TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. That is most likely also fixable. Although I understand that the gain may be less than the effort. TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Susannaanas Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Abbe98
Abbe98 added a comment. Worth noting is that this would make the template usages that pull data from Wikidata incompatible with many of the map tools including Wikimaps Warper. TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T252259: Refine Commons Template:Map with Lua modules to populate the template with Wikidata

2020-05-09 Thread Susannaanas
Susannaanas added a comment. I'm up for working with you if @Jarekt can give advise! TASK DETAIL https://phabricator.wikimedia.org/T252259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Susannaanas Cc: TiagoLubiana, Jarekt, Aklapper,