[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[hashar]

hashar added a comment.


  The last match for `AffectedPagesFinder` in logstash is at 10:52 UTC today. 
Half an hour before the fix got deployed. Seems like that fixed it.
  
  I am dropping this task from the list of train blocker, we can close it in a 
few hours if there is no other occurrences.
  
  Thank you for the quick fix and deployment!

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, hoo, Addshore, thiemowmde, DannyS712, 
Liuxinyu970226, hashar, Aklapper, darthmon_wmde, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Backport deployed. In the past 24 hours, Logstash has mostly had a handful of 
occurrences of this per hour (from group0 and group1); I’ll check later if 
those are gone now.

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, hoo, Addshore, thiemowmde, DannyS712, 
Liuxinyu970226, hashar, Aklapper, Blissjay007, Oblanco79, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2020-05-18T11:25:22Z] 
 Synchronized 
php-1.35.0-wmf.32/extensions/Wikibase/: SWAT: [[gerrit:596616|Fix core's 
TitleFactory not being used correctly (T252803 
)]] (duration: 01m 12s)

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, hoo, Addshore, thiemowmde, DannyS712, 
Liuxinyu970226, hashar, Aklapper, Blissjay007, Oblanco79, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[gerritbot]

gerritbot added a comment.


  Change 596616 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.32] Fix core's TitleFactory not 
being used correctly
  
  https://gerrit.wikimedia.org/r/596616

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, hoo, Addshore, thiemowmde, DannyS712, 
Liuxinyu970226, hashar, Aklapper, Blissjay007, Oblanco79, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[hashar]

hashar added a comment.


  It does not seem too bad indeed.  Thank you @thiemowmde for the detailed 
analysis!

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, hoo, Addshore, thiemowmde, DannyS712, 
Liuxinyu970226, hashar, Aklapper, Blissjay007, Oblanco79, Alter-paule, 
Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[gerritbot]

gerritbot added a comment.


  Change 596616 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.32] Fix core's TitleFactory not 
being used correctly
  
  https://gerrit.wikimedia.org/r/596616

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, hoo, Addshore, thiemowmde, DannyS712, Liuxinyu970226, hashar, 
Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[gerritbot]

gerritbot added a comment.


  Change 596543 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Fix core's TitleFactory not being used 
correctly
  
  https://gerrit.wikimedia.org/r/596543

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, hoo, Addshore, thiemowmde, DannyS712, Liuxinyu970226, hashar, 
Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[thiemowmde]

thiemowmde added a comment.


  This is caused by https://gerrit.wikimedia.org/r/594610, merged 9 days ago.
  
  Wikibase had a custom TitleFactory that was introduced very early, in 2014, 
see https://gerrit.wikimedia.org/r/168579. The duplicate in core was introduced 
very late, in 2019, see https://gerrit.wikimedia.org/r/543918. It looks like 
the duplicate in core was created from scratch, not being aware of the one in 
Wikibase. This might be why the two behave slightly different. The newer one 
returns null in a few more cases, where the old one was throwing exceptions.
  
  I checked all callers and fixed them in https://gerrit.wikimedia.org/r/596543.
  
  This was clearly a mistake when reviewing 
https://gerrit.wikimedia.org/r/596543 (which I was involved in ), plus there 
was obviously not a single test case triggering any of these code paths.  I 
hope we don't need to revert the change, but can backport the much smaller fix.

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, DannyS712, Liuxinyu970226, hashar, Aklapper, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null

[gerritbot]

gerritbot added a comment.


  Change 596543 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [mediawiki/extensions/Wikibase@master] Fix core's TitleFactory not being used 
correctly
  
  https://gerrit.wikimedia.org/r/596543

TASK DETAIL
  https://phabricator.wikimedia.org/T252803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: DannyS712, Liuxinyu970226, hashar, Aklapper, darthmon_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs