gerritbot added a comment.
Change 355230 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Allow specifying a non-local globalSiteId in getEntityIdForTitle
https://gerrit.wikimedia.org/r/355230TASK DETAILhttps://phabricator.wikimedia.org/T74815EMAIL
Tpt added a comment.
To summary, currently mw.wikibase.getEntityIdForTitle allows to retrieve the id of the item connected to a page of the current wiki from its title as a string.
The improvement paths I see are:
Allow the parameter to be a mw.title.Title object
Allow to retrieve the item id
petr.matas added a comment.
It seems that even some usage is tracked, although I am not sure if it is 100% correct: Employment of the new function leads to the following text appearing in the Edit source page:
Wikidata entities used in this page
United States of America: Title
TASK
petr.matas added a comment.
mw.wikibase.getEntityIdForTitle( pageTitle ) seems to work as expected at testwiki:Template talk:Country ID.
Although I advocated for support of mw.title, now I suggest to keep things simple and as the next step add
mw.wikibase.getEntityIdForTitle( pageTitle,
gerritbot added a comment.
Change 357126 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Adds mw.wikibase.getEntityIdForTitle to Scribunto
https://gerrit.wikimedia.org/r/357126TASK DETAILhttps://phabricator.wikimedia.org/T74815EMAIL
petr.matas added a comment.
For the sake of naming consistency, maybe the new function's name should be mw.wikibase.getEntityIdForSitelink because we already have functions mw.wikibase.sitelink and mw.wikibase.entity:getSitelink. The latter has an optional parameter globalSiteId with values like
petr.matas added a comment.
Someone please review @Tpt's patch mentioned in T74815#3314217. The most important functionality is already there and we have been waiting for it for years. That part of API is not going to be affected by the discussion of the final API.TASK
Tpt added a comment.
No the syntax should not be tied to "current wiki", as this makes it of little use for Commons, Wikisource, etc. There should be alternative syntax mw.wikibase.getEntityIdForTitle( pageTitle, globalSiteId ) -> string|null with globalSiteId the same as in
Jarekt added a comment.
In T74815#3314217, @Tpt wrote:
The plan is to have at least one function mw.wikibase.getEntityIdForTitle( pageTitle ) -> string|null that returns the entity id of the item related to the page on the current wiki with for title pageTitle.
No the syntax should not be tied
petr.matas added a comment.
In T74815#3314217, @Tpt wrote:
Some questions remain :
The mw.title object is a strong weapon, which solves all remaining questions: If mw.wikibase.getEntityIdForTitle(titleString) is a shorthand for mw.wikibase.getEntityIdForTitle(mw.title.new(titleString)), we will
Tpt added a comment.
To summary the current state of the work on this task:
The plan is to have at least one function mw.wikibase.getEntityIdForTitle( pageTitle ) -> string|null that returns the entity id of the item related to the page on the current wiki with for title pageTitle. It is
gerritbot added a comment.
Change 357126 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikibase@master] Adds mw.wikibase.getEntityIdForTitle to Scribunto
https://gerrit.wikimedia.org/r/357126TASK DETAILhttps://phabricator.wikimedia.org/T74815EMAIL
gerritbot added a comment.
Change 355230 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikibase@master] Adds mw.wikibase.getItemIdForLink to Scribunto
https://gerrit.wikimedia.org/r/355230TASK DETAILhttps://phabricator.wikimedia.org/T74815EMAIL
Jan_Dittrich added a comment.
I just wondered if there are any updates on this. In case it is still stuck, we may want to make the blockers transparent.TASK DETAILhttps://phabricator.wikimedia.org/T74815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
14 matches
Mail list logo
