[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [preparation in `CheckConstraintParameters`](https://gerrit.wikimedia.org/r/411307) - [ - [x] [add support in `ConstraintParameterException`](https://gerrit.wikimedia.org/r/411308) - [ - [x] minor `ViolationMessageRenderer` fixes [1](https://gerrit.wikimedia.org/r/412689), [2](https://gerrit.wikimedia.org/r/412690) - [ - [x] [update `ConstraintParameterParser`](https://gerrit.wikimedia.org/r/411309) - [ - [x] [evict old-style CPE serializations](https://gerrit.wikimedia.org/r/412675)TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [preparation in `DelegatingConstraintChecker` + tests](https://gerrit.wikimedia.org/r/411305) - [ - [x] [preparation in `SparqlHelper`](https://gerrit.wikimedia.org/r/411306) - [ - [x] [preparation in `CheckConstraintParameters`](https://gerrit.wikimedia.org/r/411307)...TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [inject serializers](https://gerrit.wikimedia.org/r/410420) - [ - [x] [preparation in tests](https://gerrit.wikimedia.org/r/411303) - [ - [x] [preparation in `ConstraintParameterException`](https://gerrit.wikimedia.org/r/411304) - [ - [x] [preparation in `DelegatingConstraintChecker` + tests](https://gerrit.wikimedia.org/r/411305)...TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [add support in `ConstraintParameterException`](https://gerrit.wikimedia.org/r/411308) - [ ] minor `ViolationMessageRenderer` fixes [1](https://gerrit.wikimedia.org/r/412689), [2](https://gerrit.wikimedia.org/r/412690) - [ ] [update `ConstraintParameterParser`](https://gerrit.wikimedia.org/r/411309)...TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [ ] [update `ConstraintParameterParser`](https://gerrit.wikimedia.org/r/411309) - TODO: start aggressively - [ ] [evicting old-style CPE serializations when refreshing the regex cache for a given regex](https://gerrit.wikimedia.org/r/412675)TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [inject serializers](https://gerrit.wikimedia.org/r/410420) More to come- [ ] [preparation in tests](https://gerrit.wikimedia.org/r/411303) - [ ] [preparation in `ConstraintParameterException`](https://gerrit.wikimedia.org/r/411304) - [ ] [preparation in `DelegatingConstraintChecker` + tests](https://gerrit.wikimedia.org/r/411305) - [ ] [preparation in `SparqlHelper`](https://gerrit.wikimedia.org/r/411306) - [ ] [preparation in `CheckConstraintParameters`](https://gerrit.wikimedia.org/r/411307) - [ ] [add support in `ConstraintParameterException`](https://gerrit.wikimedia.org/r/411308) - [ ] [update `ConstraintParameterParser`](https://gerrit.wikimedia.org/r/411309) - TODO: start aggressively evicting old-style CPE serializations when refreshing the regex cache for a given regexTASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...#patch-for-review: - [ - [x] [inject serializers](https://gerrit.wikimedia.org/r/410420) More to comeTASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Note that this requires {T185999}, since CPEs are serialized and deserialized by `SparqlHelper` in the regex cache.
#patch-for-review:
- [ ] [inject serializers](https://gerrit.wikimedia.org/r/410420)TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONMake `ConstraintParameterException` accept a `ViolationMessage` instead of a `string`. (For a short transition period, probably both, just like `ViolationMessageRenderer::render`.) The string message passed to the superclass constructor can probably just be the message key – it should never be seen anyways.
Note that this requires {T185999}, since CPEs are serialized and deserialized by `SparqlHelper` in the regex cache.TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T187186: Use ViolationMessage in ConstraintParameterException
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONMake `ConstraintParameterException` accept a `ViolationMessage` instead of a `string`. (For a short transition period, probably both, just like `ViolationMessageRenderer::render`.) The string message passed to the superclass constructor can probably just be the message key – it should never be seen anyways.TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
