[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...**Code pointer**: the entered lang code is checked using validator provided by LexemeValidatorFactory::getLanguageCodeValidator **NOTE**: as of 25.04.2018 the language code validation is not strict enough, as "de-x-foobar" would be recognized as the valid language, whereas it has been defined that a valid language code should include a Q-ID-like string after '-x-' tag.TASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- if the input contains a part '-x-' in it, the part before '-x-' is a language code recognized as valid by "core" wikibase, and the part after '-x-' is of form: 'Q' followed by digits == Examples of valid language codes ==...- de-Q1996 - de-x-foobar - de-x-Q1996-foobar - foobar-x-Q1996...TASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* It is impossible to add a **lemma** using thean **invalid language code** * It is impossible to add a **form representation** using thean **invalid language code**...TASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...THEN I see the representation with invalid language code has not been saved **Code pointer:**: the entered lang code is checked using validator provided by LexemeValidatorFactory::getLanguageCodeValidatorTASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- foobar-x-Q1996 TBA: describe the behaviour visible by user in a BDD style (no error message shown, but not storing invalid data)= Scenarios = == Invalid language code for lemma == GIVEN I am on the lexeme page AND I click edit button of the lexeme header AND I click add lemma button WHEN I enter lemma text AND I enter invalid language code AND I click save AND I reload the page THEN I see the lemma with invalid language code has not been saved == Invalid language code for representation == GIVEN I am on the page of a lexeme with a form AND I click edit button of the form AND I click add representation button WHEN I enter representation text AND I enter invalid language code AND I click save AND I reload the page THEN I see the representation with invalid language code has not been saved Code pointer: the entered lang code is checked using validator provided by LexemeValidatorFactory::getLanguageCodeValidatorTASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...== Examples of valid language codes == - en - de...TASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...{F16745033}
Leszek dug up how the validation is currently done:= Acceptance criteria =
* It is impossible to add a **lemma** using the **invalid language code**
* It is impossible to add a **form representation** using the **invalid language code**
Invalid language code here means any string other then the valid language code, defined for the scope of this task as follows:
- the string which is a language code recognized as valid by "core" wikibase
- if the input contains a part '-x-' in it, the part before '-x-' is a language code recognized as valid by "core" wikibase
== Examples of valid language codes ==
- en
- de
- de-at
- de-x-Q1996
== Examples of invalid language codes ==
* check whether the entered language code is the language code recognized as valid by "core" wikibase- foobar
* in case the user input lang code is not valid that way, the extra check happens- de-Q1996
* if the input contains a part '-x-' in it, the part before '-x-' is taken, and validated the same way as above. In other words. Assuming "de" is a valid wikibase lang code, and "foo" is not, for lemma and representation language the following stuff is considered valid: de, de-x-Q666, de-x-yolo. And the following are to be considered invalid: foo, foo-x-Q666, foo-x-yolo, de-yolo, de-Q66- foobar-x-Q1996...TASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* if the input contains a part '-x-' in it, the part before '-x-' is taken, and validated the same way as above. In other words. Assuming "de" is a valid wikibase lang code, and "foo" is not, for lemma and representation language the following stuff is considered valid: de, de-x-Q666, de-x-yolo. And the following are to be considered invalid: foo, foo-x-Q666, foo-x-yolo, de-yolo, de-Q666 TBA: describe the behaviour visible by user in a BDD style (no error message shown, but not storing invalid data) Code pointer: the entered lang code is checked using validator provided by LexemeValidatorFactory::getLanguageCodeValidatorTASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191504: inconsistency between language fields on the Lexeme page
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* the entered lang code is checked using validator provided by LexemeValidatorFactory::getLanguageCodeValidator (which to be less technically direct means it validates that thecheck whether the entered language code is the language code recognized as valid by "core" wikibase) * in case the user input lang code is not valid that way, the extra check happens * if the input contains a part '-x-' in it, the part before '-x-' is taken, and validated the same way as above. In other words. Assuming "de" is a valid wikibase lang code, and "foo" is not, for lemma and representation language the following stuff is considered valid: de, de-x-Q666, de-x-yolo. And the following are to be considered invalid: foo, foo-x-Q666, foo-x-yolo, de-yolo, de-Q666 Code pointer: the entered lang code is checked using validator provided by LexemeValidatorFactory::getLanguageCodeValidatorTASK DETAILhttps://phabricator.wikimedia.org/T191504EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Aklapper, Lydia_Pintscher, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
