[Wikidata-bugs] [Maniphest] [Edited] T191872: Lexeme header widget should handle API errors
Lydia_Pintscher updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...THEN The error message "An error has occurred: The last Lemma can not be removed." is displayed...AND One of API error occurs THEN The error message !!TODO specify!!!"An error has occurred: save has failed" or "An error has occurred: unexpected error" is displayed...TASK DETAILhttps://phabricator.wikimedia.org/T191872EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, WMDE-leszek, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191872: Lexeme header widget should handle API errors
Lydia_Pintscher updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...THEN The error message !!TODO specify!!!"An error occurred: The last Lemma can not be removed." is displayed...TASK DETAILhttps://phabricator.wikimedia.org/T191872EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, WMDE-leszek, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191872: Lexeme header widget should handle API errors
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONLexeme header makes calls to the API while saving changes made by the user. In case some error happens (e.g. invalid data has been provided), the API returns the error response. Currently, the widget silently ignores the errors. It switches to non-edit mode and looks like the changes have been saved. In fact, those changes have not been saved, as reloading the page proves. Not saving invalid data is good, but the widget should also not pretend all was OK to the user, and surface the API errors to the user. =Acceptance criteria:= When the API response contains the error, it is displayed to the user using the standard "error bubble". =Scenarios= GIVEN I am on the lexeme page...THEN The error message !!TODO specify!!! is displayed ===API errors:=== - Save has failed...TASK DETAILhttps://phabricator.wikimedia.org/T191872EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, WMDE-leszek, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T191872: Lexeme header widget should handle API errors
WMDE-leszek updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...API errors: - ...- Save has failed - unexpected error TASK DETAILhttps://phabricator.wikimedia.org/T191872EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, WMDE-leszek, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
