[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[matej_suchanek]

matej_suchanek added a comment.


  > It looks like this perhaps happened with T196882 
 and or T229280 

  
  I think it was you in T245740  
(the RedirectResolvingLatestRevisionLookup stuff?). Perhaps T127169 
 should get the same update as some 
projects may not use Lua.
  
  > [X] LUA functions do resolve redirects (done in patches of unrelated 
tickets?)
  
  Note that //both// `mw.wikibase.getLabelByLang` and `mw.wikibase.getSitelink` 
don't work. So it's partly (mostly) done.

TASK DETAIL
  https://phabricator.wikimedia.org/T157868

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Addshore, Vriullop, Tomukas, Mike_Peel, RexxS, Bugreporter, Ahecht, 
Dipsacus_fullonum, eranroz, Uzume, Salgo60, Larske, hoo, matej_suchanek, 
Aklapper, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[Addshore]

Addshore added a comment.


  I went and looked through the code and it doesn't look like anything has 
changed here in the last years regarding the entity lookup and revision 
resolving specifically for LUA.
  
  It looks like this perhaps happened with T196882 
 and or T229280 

  
  > Having some regression test would be good.
  
  There already is for the bits of code touched in the 2 linked ticket, 
although not an integration or e2e test for the high level LUA integration.
  
  > Note the inconsistency between getLabel and getLabelByLang.
  
  IT might be worth popping that in another ticket!

TASK DETAIL
  https://phabricator.wikimedia.org/T157868

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Vriullop, Tomukas, Mike_Peel, RexxS, Bugreporter, Ahecht, 
Dipsacus_fullonum, eranroz, Uzume, Salgo60, Larske, hoo, matej_suchanek, 
Aklapper, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[Lydia_Pintscher]

Lydia_Pintscher added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T157868

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Mike_Peel, RexxS, Bugreporter, Ahecht, Dipsacus_fullonum, eranroz, Uzume, 
Salgo60, Larske, hoo, matej_suchanek, Aklapper, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[eranroz]

eranroz added a comment.

In T157868#4142305, @Uzume wrote:
This might get resolved by T112658.


Tested it (for label) with the patchset suggested in T112658 but this will not resolve it - requiring a different fix as part of T142950TASK DETAILhttps://phabricator.wikimedia.org/T157868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: eranroz, Uzume, Salgo60, Larske, hoo, matej_suchanek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[Uzume]

Uzume added a comment.
This might get resolved by T112658.TASK DETAILhttps://phabricator.wikimedia.org/T157868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UzumeCc: Uzume, Salgo60, Larske, hoo, matej_suchanek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[Uzume]

Uzume added a comment.
T143970 seems like it was recently closed but I still think we need a resolveEntityId(eid) that returns nil when there is no such entity but redirects for merged items, etc. It could also potentially work like resolvePropertyId and return a valid entity ID when given an unambiguous label or alias.TASK DETAILhttps://phabricator.wikimedia.org/T157868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: UzumeCc: Uzume, Salgo60, Larske, hoo, matej_suchanek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[hoo]

hoo added a project: Wikibase-Lua.
TASK DETAILhttps://phabricator.wikimedia.org/T157868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: Salgo60, Larske, hoo, matej_suchanek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[matej_suchanek]

matej_suchanek added a subtask: T142950: Implement an item redirect resolving TermLookup.
TASK DETAILhttps://phabricator.wikimedia.org/T157868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T157868: Lua functions do not resolve redirects

[matej_suchanek]

matej_suchanek added a parent task: T112073: Lua in Wikibase (tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T157868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs