[Wikidata-bugs] [Maniphest] [Updated] T167565: Wikidata allows invalid URIs to be entered as units

[Addshore]

Addshore added a subtask: T238734: Add configurable validation for units, 
calendar models and globes..

TASK DETAIL
  https://phabricator.wikimedia.org/T167565

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Lea_Lacroix_WMDE, MisterSynergy, abian, Mbch331, matej_suchanek, 
Pasleim, PokestarFan, Lydia_Pintscher, Ladsgroup, thiemowmde, daniel, Aklapper, 
Smalyshev, darthmon_wmde, Dinadineke, DannyS712, Nandana, tabish.shaikh91, 
Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, 
QZanden, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, 
Wikidata-bugs, aude, TheDJ
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T167565: Wikidata allows invalid URIs to be entered as units

[matej_suchanek]

matej_suchanek added a comment.


  Duplicate of T112082: [Bug] QuantityParser must pass-through valid unit 
representations ?

TASK DETAIL
  https://phabricator.wikimedia.org/T167565

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Lea_Lacroix_WMDE, MisterSynergy, abian, Mbch331, matej_suchanek, Pasleim, 
PokestarFan, Lydia_Pintscher, Ladsgroup, thiemowmde, daniel, Aklapper, 
Smalyshev, alaa_wmde, Dinadineke, Nandana, tabish.shaikh91, Lahi, Gq86, 
GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, 
merbst, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, TheDJ
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T167565: Wikidata allows invalid URIs to be entered as units

[Lea_Lacroix_WMDE]

Lea_Lacroix_WMDE added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T167565

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: Lea_Lacroix_WMDE, MisterSynergy, abian, Mbch331, matej_suchanek, Pasleim, 
PokestarFan, Lydia_Pintscher, Ladsgroup, thiemowmde, daniel, Aklapper, 
Smalyshev, alaa_wmde, Dinadineke, Nandana, tabish.shaikh91, Lahi, Gq86, 
GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, 
merbst, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, TheDJ
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T167565: Wikidata allows invalid URIs to be entered as units

[daniel]

daniel added a parent task: T77977: [Epic] Unit support .Herald added a subscriber: PokestarFan.
TASK DETAILhttps://phabricator.wikimedia.org/T167565EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: PokestarFan, Lydia_Pintscher, Ladsgroup, thiemowmde, daniel, Aklapper, Smalyshev, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T167565: Wikidata allows invalid URIs to be entered as units

[thiemowmde]

thiemowmde added a subscriber: Lydia_Pintscher.thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Need-volunteer.thiemowmde added a comment.
The relevant validation currently done in ValidatorBuilders.php is a substring match for http://www.wikidata.org/entity/. This already disallows all …/wiki/ URLs. Namespace, entity type, and entity ID are currently not validated.

It should not be that hard to create a validator that only accepts a single entity type (or a set of entity types), checks the namespace (note that items can be in the main namespace, or in an "Item:" namespace), parses the entity ID, and makes sure it matches the entity type. Service classes for all these individual checks should already exist (probably EntityNamespaceLookup and an EntityIdParser).

Note that calendar model and globe URIs are missing the exact same validation. It's probably a good idea to have a single ticket for all three.TASK DETAILhttps://phabricator.wikimedia.org/T167565EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Lydia_Pintscher, Ladsgroup, thiemowmde, daniel, Aklapper, Smalyshev, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Kaartic, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs