[Wikidata-bugs] [Maniphest] [Updated] T207479: Fatal error from Lexeme API: "InvalidArgumentException: Not a lexeme ID"

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  In T207479#5047665 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T207479#5045866 , 
@Jdforrester-WMF wrote:
  >
  > > The link in the description now results in production in a 200 -> API 
error response (shouldn't that be a 40x?)
  >
  >
  > I thought the Action API always returns 200 (unless an internal error 
occurs)? For example, `action=query=Does not exist` doesn’t return 404 
Not Found either.
  
  
  Yeah, this is T26144: Invalid action page should probably not have HTTP 
status 200 , not specific to this 
API. :-)

TASK DETAIL
  https://phabricator.wikimedia.org/T207479

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, Jdforrester-WMF
Cc: Jdforrester-WMF, Liuxinyu970226, gerritbot, Addshore, 
Lucas_Werkmeister_WMDE, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Mringgaard, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Darkdadaah, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T207479: Fatal error from Lexeme API: "InvalidArgumentException: Not a lexeme ID"

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T207479

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, ReleaseTaggerBot
Cc: Liuxinyu970226, gerritbot, Addshore, Lucas_Werkmeister_WMDE, alaa_wmde, 
CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T207479: Fatal error from Lexeme API: "InvalidArgumentException: Not a lexeme ID"

[Addshore]

Addshore added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T207479EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alaa_wmde, AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T207479: Fatal error from Lexeme API: "InvalidArgumentException: Not a lexeme ID"

[Addshore]

Addshore added a comment.
From the investigation (T209368) we want to do the following

1 - ValueFormatter interface
The ValueFormatter interface should be documented as allowing InvalidArgumentExceptions to be thrown when arguments are known to be wrong for the type of Formatter instance.
Many instances of ValueFormatter already do this, but lets add it to the interface documentation.

2 - EntityIdFormatter interface
EntityIdFormatter interface should also document throwing an InvalidArgumentException when being provided with an argument that the current formatter can not format.

3 - FormatSnakValue API
EntityIdValueFormatter::format itself already throws InvalidArgumentExceptions, and the 2 cases above bubble up through this method.
When $valueFormatter->format is called in the FormatSnakValue API, InvalidArgumentExceptions from the call should be caught and exposed to the user as a regular API error, not an exception.TASK DETAILhttps://phabricator.wikimedia.org/T207479EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T207479: Fatal error from Lexeme API: "InvalidArgumentException: Not a lexeme ID"

[Addshore]

Addshore edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).Addshore added a comment.
During the task breakdown we realized that the "right" thing to do probably isn't to catch these exceptions and show an error.
So we will boot it back into the #wikidata-campsite and pick up an investigation task instead.TASK DETAILhttps://phabricator.wikimedia.org/T207479EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T207479: Fatal error from Lexeme API: "InvalidArgumentException: Not a lexeme ID"

[Addshore]

Addshore set the point value for this task to "3".
TASK DETAILhttps://phabricator.wikimedia.org/T207479EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lucas_Werkmeister_WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T207479: Fatal error from Lexeme API: "InvalidArgumentException: Not a lexeme ID"

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.
TASK DETAILhttps://phabricator.wikimedia.org/T207479EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs