[Wikidata-bugs] [Maniphest] [Updated] T248840: Don’t polyfill Promise in Bridge modules

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T248840

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, Lucas_Werkmeister_WMDE, Aklapper, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, Pablo-WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T248840: Don’t polyfill Promise in Bridge modules

[Michael]

Michael edited projects, added Technical Improvements; removed Wikidata-Bridge.
Michael added a comment.


  @Lucas_Werkmeister_WMDE  and I looked into this today and encountered some 
problems with getting this to work. While it is correct that the promise 
polyfill is included by default (vuejs/vue-cli#1248 
, vuejs/vue-cli#5208 
), it should be possible to 
change that with the following as `babel.config.js` (possible trimming 
`polyfills` if those default polyfills are not needed):
  
module.exports = {
presets: [
[ '@vue/cli-plugin-babel/preset', {
exclude: [
'es.promise', // polyfilled via es6-promise 
ResourceLoader module instead
],
polyfills: [ 'es.array.iterator', 'es.object.assign' ],
} ],
],
};
  
  However, that currently doesn't prevent the `es.promise` polyfill from being 
included.
  
  The cause is to be found in `@vue/babel-preset-app` which is included by our 
`@vue/cli-plugin-babel/preset`.
   This handles the `exclude` parameter correctly through most of the file, but 
at the end 

 it requires `@babel/preset-env` again, but without including the preset 
options that were carefully constructed through that file. The cause for this 
seems to have been a bug in babel itself 
 for which adding that extra 
transpilation seems to be the recommended workaround 
. It is unclear whether that 
necessitates the inclusion of the promise polyfill. An upstream pull request 
 to use the envOptions also for 
that transpilation was created by @Lucas_Werkmeister_WMDE . Further it seems 
that the original babel bug was resolved 
 and the 
respective file in vue-cli is actively being worked on 
.
  
  So there is some hope that this improvement can be implemented soon™.
  
  (@Lucas_Werkmeister_WMDE feel free to correct me if my summary above can be 
improved)

TASK DETAIL
  https://phabricator.wikimedia.org/T248840

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, 
Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T248840: Don’t polyfill Promise in Bridge modules

[Krinkle]

Krinkle added a parent task: T246456: Performance review of Wikidata Bridge.

TASK DETAIL
  https://phabricator.wikimedia.org/T248840

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs