[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-06-17 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Lydia_Pintscher, daniel, Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, 
Aklapper, DannyS712, Naike, eprodromou, darthmon_wmde, Nandana, lucamauri, 
Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Izno, 
Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, CucyNoiD, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, 
Liugev6, WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-06-17 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.38; 
2020-06-23); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lydia_Pintscher, daniel, Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, 
Aklapper, DannyS712, Naike, Blissjay007, Oblanco79, Alter-paule, Beast1978, 
Un1tY, eprodromou, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Amorymeltzer, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-06-15 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, daniel, Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, 
Aklapper, DannyS712, Naike, Blissjay007, Oblanco79, Alter-paule, Beast1978, 
Un1tY, eprodromou, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Amorymeltzer, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-06-10 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Lydia_Pintscher, daniel, Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, 
Aklapper, DannyS712, Naike, eprodromou, darthmon_wmde, Nandana, lucamauri, 
Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, 
LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Izno, 
Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, CucyNoiD, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, 
Liugev6, WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-06-10 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lydia_Pintscher, daniel, Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, 
Aklapper, DannyS712, Naike, Blissjay007, Oblanco79, Alter-paule, Beast1978, 
Un1tY, eprodromou, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Amorymeltzer, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-06-09 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, daniel, Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, 
Aklapper, DannyS712, Naike, Blissjay007, Oblanco79, Alter-paule, Beast1978, 
Un1tY, eprodromou, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Amorymeltzer, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-04-28 Thread Addshore 
Addshore added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, Aklapper, DannyS712, 
eprodromou, darthmon_wmde, Nandana, lucamauri, Amorymeltzer, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Pchelolo, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T249563: Hard deprecate WikiPage::doEditUpdates

2020-04-27 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a subscriber: Ladsgroup.
Lucas_Werkmeister_WMDE added a comment.


  This `SqlStore::rebuild()` method seems to date back to 2012 
, with relatively little substantial 
changes since then. Apart from one test, it’s only called in 
`DatabaseSchemaUpdater::doSchemaUpdate()`, when updating from older database 
schemas. My guess is that the method is really meant to “rebuild the entity 
store”; maybe we used to register deferred edit updates to migrate stored 
revisions to a new serialization schema, and calling `doEditUpdates()` in this 
`rebuild()` method was meant to do the same thing for all pages, even if they 
hadn’t received an edit lately (and therefore didn’t get a deferred edit update 
through the normal route).
  
  It’s worth noting that, as far as I’m aware, Wikibase hasn’t actually been 
updating old revisions for a long time now; instead, Wikibase can parse old 
serialization formats for the purpose of reading old revisions (but will only 
write new revisions with the latest serialization format). Also, 
`SqlStore::rebuild()` will only actually rebuild the first 1000 pages (“TODO: 
continuation”), so it would only do the right thing when upgrading very old 
Wikibases that are also very small (because, no matter whether the `rebuild()` 
touched all pages or only some of them, the rest of 
`DatabaseSchemaUpdater::doSchemaUpdate()` will have run already, and so the 
next database updates will no longer end up calling `rebuild()`).
  
  @Ladsgroup might have something to add because he also looked at related code 
recently (that same Gerrit change also caused T249565 
, I believe).

TASK DETAIL
  https://phabricator.wikimedia.org/T249563

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Addshore, Lucas_Werkmeister_WMDE, Aklapper, DannyS712, 
eprodromou, darthmon_wmde, Nandana, lucamauri, Amorymeltzer, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Pchelolo, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs