[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-25 Thread Lydia_Pintscher 
Lydia_Pintscher closed subtask T152425: Use varnish xkey to purge output of 
Special:EntityData when appropriate as Declined.

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, Lydia_Pintscher
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, 
Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-25 Thread Lydia_Pintscher 
Lydia_Pintscher closed this task as "Resolved".
Lydia_Pintscher moved this task from Test (Verification) to Done on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lydia_Pintscher added a comment.


  \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, Lydia_Pintscher
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, 
Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-14 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, Maintenance_bot
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, 
Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-14 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, ReleaseTaggerBot
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-14 Thread gerritbot 
gerritbot added a comment.


  Change 620318 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Cache Special:EntityData only if 
revision supplied
  
  https://gerrit.wikimedia.org/r/620318

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, gerritbot
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-14 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, gerritbot
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-14 Thread gerritbot 
gerritbot added a comment.


  Change 620318 had a related patch set uploaded (by Tarrow; owner: Tarrow):
  [mediawiki/extensions/Wikibase@master] Cache Special:EntityData only if 
revision supplied
  
  https://gerrit.wikimedia.org/r/620318

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow, gerritbot
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, 
Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-13 Thread Tarrow 
Tarrow added subscribers: guergana.tzatchkova, Tarrow.
Tarrow claimed this task.
Tarrow added a comment.


  Working on this with @guergana.tzatchkova

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Tarrow, guergana.tzatchkova, WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, 
Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, 
mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, 
Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-13 Thread Ladsgroup 
Ladsgroup added a comment.


  I have a feeling that the original code didn't take into account how 
varnish/ATS works (or it worked differently back then)

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, Pablo-WMDE, WMDE-leszek, 
Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, mkroetzsch, Smalyshev, 
Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, Iflorez, alaa_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-13 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  One interesting thing is that the current code seems to expect the opposite 
situation of what we now want to introduce:
  
  name=EntityDataRequestHandler::outputData()
//FIXME: do not cache if revision was requested explicitly!
$maxAge = $request->getInt( 'maxage', $this->maxAge );
$sMaxAge = $request->getInt( 'smaxage', $this->maxAge );

// XXX: do we want public caching even for data from old revisions?
$maxAge  = max( self::MINIMUM_MAX_AGE, min( self::MAXIMUM_MAX_AGE, $maxAge 
) );
$sMaxAge = max( self::MINIMUM_MAX_AGE, min( self::MAXIMUM_MAX_AGE, $sMaxAge 
) );
  
  At the time this was written (2013: I1dabe79261 
, I7298de0b9d 
), the expectation apparently was that 
eventually, we should only cache `Special:EntityData` requests //without// a 
revision ID, not ones with a revision ID.

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, Pablo-WMDE, WMDE-leszek, 
Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, mkroetzsch, Smalyshev, 
Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, Iflorez, alaa_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-11 Thread Addshore 
Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, Pablo-WMDE, WMDE-leszek, 
Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, mkroetzsch, Smalyshev, 
Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, Iflorez, alaa_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-11 Thread Addshore 
Addshore added a comment.


  Task inspection notes:
  
  Possible 3 approaches:
  
  1. **Don't cache these requests** << Decided as the approach to try
  2. **Invalidate the cache on the edit**
- How expensive is doing the cache invalidation on edits?
- How many cache invalidations will occur after 1 edit?
  - 20 cache invalidations (5 formats, 4 flavours)
  - 20 invalidations * 1000 edits? = 20k invalidations a min potential?
- Cache invalidation has to happen at multiple edge cache sites which = 
more time etc
  3. **Make the requests without the revision id a temporary redirect to the 
page with a revision id** << Decided as the 2nd place choice if we had to 
reevaluate later
- Would this mean we don't cache the requests to the page with no revision 
id, then always send an up to date redirect, then point to a possibly cached 
page with revision id (YES)
- Could potentially be a breaking change? depending on how users make their 
API requests?
  4. **Don't cache the less used formats, do cache the more used formats and 
send purge requests** (a combination of 1 and 2)
- The motivation of this would be to send fewer purges on every edit than 
number 2

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, Pablo-WMDE, WMDE-leszek, 
Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, mkroetzsch, Smalyshev, 
Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, Iflorez, alaa_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-11 Thread Addshore 
Addshore moved this task from Prioritized Product to 
Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, Pablo-WMDE, WMDE-leszek, 
Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, mkroetzsch, Smalyshev, 
Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, Iflorez, alaa_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T128486: [Story] Make Special:EntityData be up to date after an edit

2020-08-11 Thread Addshore 
Addshore renamed this task from "[Story] Purge Special:EntityData JSON after 
edit" to "[Story] Make Special:EntityData be up to date after an edit".
Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T128486

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WDoranWMF, darthmon_wmde, Ladsgroup, Addshore, Pablo-WMDE, WMDE-leszek, 
Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, mkroetzsch, Smalyshev, 
Aklapper, StudiesWorld, Lydia_Pintscher, Akuckartz, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs