[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE assigned this task to Shubham656jain. Lucas_Werkmeister_WMDE added a comment. I think we can close this – otherwise it’ll be one of those tasks that stay open forever because there are no clear criteria for when to

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Shubham656jain removed Shubham656jain as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Shubham656jain Cc: Shubham656jain, Diwanshu885, Manu1400, Bsandipan, TerraCodes,

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Aklapper added a comment. Hi @Shubham656jain: Thanks for the quick reply! Does that mean this task is complete and should be closed? If yes then please feel free to do so. If you think that this task is not complete and you don't plan to further work on this task, it would be good to

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Shubham656jain added a comment. @Aklapper Hi! I don't seem to find any more queries to add in this task. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Shubham656jain Cc: Diwanshu885,

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Aklapper added a comment. @Shubham656jain: Hi, all related patches in Gerrit have been merged or abandoned. Is there more to do in this task? Asking as you are set as task assignee. Thanks in advance! (You can change the task status via Add Action... > Change Status in the dropdown menu.)

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

gerritbot added a comment. Change 637689 **abandoned** by Shubham656jain: [wikidata/query/gui@master] ADD autocompletion suggestion in Sparql.js Reason: https://gerrit.wikimedia.org/r/637689 TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Shubham656jain, gerritbot Cc: Diwanshu885, Manu1400, Bsandipan, TerraCodes, Jonas, Yair_rand, Aklapper,

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

gerritbot added a comment. Change 637689 had a related patch set uploaded (by Shubham656jain; owner: Shubham656jain): [wikidata/query/gui@master] ADD autocompletion suggestion in Sparql.js https://gerrit.wikimedia.org/r/637689 TASK DETAIL https://phabricator.wikimedia.org/T170364

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Shubham656jain, Maintenance_bot Cc: Diwanshu885, Manu1400, Bsandipan, TerraCodes, Jonas,

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

gerritbot added a comment. Change 637417 **merged** by jenkins-bot: [wikidata/query/gui@master] ADD autocompletion suggestion in Sparql.js https://gerrit.wikimedia.org/r/637417 TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Aklapper added a comment. Hi, see https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews - thanks TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Shubham656jain, Aklapper Cc:

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Shubham656jain added a comment. @Aklapper Can you tell me who should I ask for review as the I cannot see the author's name @Yair_rand in gerrit's Add reviewer options? TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Aklapper added a comment. @Shubham656jain: I am not a developer, and @Jonas is not an active account. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Shubham656jain, Aklapper Cc: Diwanshu885,

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Shubham656jain added a comment. @Aklapper @Jonas I have released a patch. Please review if it any modifications are required. Thanks! TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Shubham656jain claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Shubham656jain Cc: Diwanshu885, Manu1400, Bsandipan, TerraCodes, Jonas, Yair_rand, Aklapper, Annysah01,

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Diwanshu885, Manu1400, Bsandipan, TerraCodes, Jonas, Yair_rand, Aklapper, Annysah01,

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

gerritbot added a comment. Change 637417 had a related patch set uploaded (by Shubham656jain; owner: Shubham656jain): [wikidata/query/gui@master] ADD autocompletion suggestion in Sparql.js https://gerrit.wikimedia.org/r/637417 TASK DETAIL https://phabricator.wikimedia.org/T170364

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Aklapper added a comment. @Diwanshu885: That is up to you to find out, test, and verify , I would say. :) TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Diwanshu885 added a comment. @Aklapper Do I need to add the code blocks mentioned in the description in this file "https://phabricator.wikimedia.org/diffusion/WDQG/browse/master/wikibase/queryService/ui/editor/hint/Sparql.js Or something else is required? Please guide! TASK DETAIL

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Aklapper added a comment. Hi @Diwanshu885, thanks for your interest! Do you have a specific question (please read and follow https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Suggested_reading ), and can you also clarify what is unclear with the task description and comments?

[Wikidata-bugs] [Maniphest] T170364: Suggestions for auto completion suggestions

Diwanshu885 added a comment. @Yair_rand Is the issue been resolved? If not, I would like to work on this. Please guide me from where to start. I am new to MediaWiki. TASK DETAIL https://phabricator.wikimedia.org/T170364 EMAIL PREFERENCES