[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[kostajh]

kostajh added subscribers: Sgs, kostajh.
kostajh added a comment.


  I'd love to see this as well, for #growthexperiments 
 where we have a 
`documentation` site with its own package.json 

 (cc @Sgs )

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, Sgs, hashar, Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, 
Daimona, Michael, Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, 
Esanders, Astuthiodit_1, karapayneWMDE, Invadibot, Lectrician1, Zabe, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[Legoktm]

Legoktm removed Legoktm as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm
Cc: hashar, RhinosF1, Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, 
Daimona, Michael, Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, 
Esanders, Invadibot, Zabe, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[hashar]

hashar added a comment.


  An example is `mediawiki/libs/metrics-platform.git` which co host code for 
NodeJs, PHP, Swift and Java, each in their own directory having the relevant 
package manager file:
  
  | JS  | 
https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/690049 |
  | php | 
https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/676443 |

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm, hashar
Cc: hashar, RhinosF1, Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, 
Daimona, Michael, Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, 
Esanders, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[Addshore]

Addshore added a comment.


  @Legoktm we are still keen to make this work, did you have your WIP code 
somewhere? :)

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm, Addshore
Cc: RhinosF1, Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, Daimona, 
Michael, Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, Esanders, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[Addshore]

Addshore added a comment.


  @Legoktm I hear you might have something running locally?
  Anything we can help with to get this deployed? :)

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm, Addshore
Cc: Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, Daimona, Michael, 
Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, Esanders, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[Legoktm]

Legoktm claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm
Cc: Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, Daimona, Michael, 
Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, Esanders, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[Pablo-WMDE]

Pablo-WMDE added a comment.


  In T228527#6586172 , 
@Legoktm wrote:
  
  > So first, I note that ContentTranslation has seemed to gotten this working 
without any libup intervention, see e.g. 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ContentTranslation/+/ec12768a718a8bccf070a70b86c9c42afe603362
  
  The comment 

  
  > I am not sure, why the sub package-lock.json was also updated.
  > It seems the sub package-lock.json is not whitelisted for libup to 
automerge.
  
  and response 

  
  > Yeah; I think this is rare enough that it's OK to do manually.
  
  don't make it sound like that's a well know feature (if at all) and should be 
relied on. Would be great to see this functionality become a first class 
citizen (documentation et al.) before we build on top of it.
  
  It should also be noted that we did not exactly invent the idea of monorepos 
 and that - if anything - 
they can be expected to become more popular  
especially in a world of well-scoped micro frontends 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, Daimona, Michael, 
Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, Esanders, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

[Legoktm]

Legoktm added a comment.


  So first, I note that ContentTranslation has seemed to gotten this working 
without any libup intervention, see e.g. 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ContentTranslation/+/ec12768a718a8bccf070a70b86c9c42afe603362
  
  I believe this works because of 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ContentTranslation/+/refs/heads/master/package.json
 where `npm test` runs both the main test and the sub test. Would doing 
something like that work for the Wikibase repos?
  
  For actually implementing this in libup, recursing through subdirectories to 
run the `npm ...` commands should be straightforward. The main technical issue 
would be how to represent dependencies in libup's internal tracking database, 
especially if they're conflicting. For now, I think we could internally pretend 
each nested package.json is a separate repository with some fake name like 
`mediawiki/extensions/Wikibase:client/data-bridge/package.json`.

TASK DETAIL
  https://phabricator.wikimedia.org/T228527

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm
Cc: darthmon_wmde, WMDE-leszek, Addshore, Daimona, Michael, Legoktm, 
Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, Esanders, Akuckartz, 
Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs