[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-31 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. In T259211#6420663 , @matej_suchanek wrote: > Does this concern Wikidata, too? There are some gadgets using RepoApi

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-29 Thread matej_suchanek
matej_suchanek removed a project: Patch-For-Review. matej_suchanek added a comment. > I highly recommend not using this module anymore. Does this concern Wikidata, too? There are some gadgets using RepoApi

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-28 Thread Addshore
Addshore added a comment. Just pointing out (as it has not been stated above) but you can still talk to the Wikidata / REPO API without using the code in RepoApi, so losing access to this shouldn't block you from doing things. Specifically re adding such code as a feature to be maintained

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Indeed, JS consumers of Wikibase should never have relied on it in the first place, because Wikibase’s JS code is not a stable interface. TASK DETAIL https://phabricator.wikimedia.org/T259211 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-21 Thread eranroz
eranroz closed this task as "Declined". eranroz added a comment. it's disappointing that JS API that was just exposing the PHP API (part of it) and that is used used by Wikibase itself, isn't available anymore for other consumers :-( Anyway it seems like JS consumers of wikibase should

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-21 Thread gerritbot
gerritbot added a comment. Change 621498 **abandoned** by Eranroz: [mediawiki/extensions/Wikibase@master] Revert "Migrate wikibase.api module to repo and use it directly in client" Reason: https://gerrit.wikimedia.org/r/621498 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Just because we don’t advertise the JS API for other extensions, gadgets, or user scripts does not mean we have to remove it internally and change all its uses. TASK DETAIL https://phabricator.wikimedia.org/T259211 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-20 Thread eranroz
eranroz added a subscriber: daniel. eranroz added a comment. @Ladsgroup @daniel I would like to understand what is the approach we would like to go for the long run: - Do we want to have JS api for other extensions (the current and future use cases I can think of are Content

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-20 Thread gerritbot
gerritbot added a comment. Change 621498 had a related patch set uploaded (by Eranroz; owner: Eranroz): [mediawiki/extensions/Wikibase@master] Revert "Migrate wikibase.api module to repo and use it directly in client" https://gerrit.wikimedia.org/r/621498 TASK DETAIL

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-20 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T259211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lydia_Pintscher, 0x010C, vlsergey, Krinkle, Lucas_Werkmeister_WMDE, Ladsgroup, Aklapper,

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-04 Thread eranroz
eranroz added a comment. In T259211#6347466 , @Ladsgroup wrote: > but in the mean time you can still mark `jquery.wikibase.linkitem` as the dependency instead and use the global variable but I don't recommend it. This by itself

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. In T259211#6358890 , @Lydia_Pintscher wrote: > Are there specific gadgets for example that are broken now? See Amir’s comment (T259211#6347466

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-04 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. In order to move forward with this I'd like to understand the specifics of what people are trying to achieve. Are there specific gadgets for example that are broken now? What data do they need access to? For what? TASK DETAIL

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-03 Thread eranroz
eranroz added a comment. - Wikidata (wikidata client only) and communities (frwiki, hewiki, ruwiki) code is misaligned by removing JS API interface to wikidata that is used by gadgets -> functionality broken -> regression. to get it resolved we need to re-align them - communities code

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-03 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE removed a project: Regression. Lucas_Werkmeister_WMDE added a comment. Intentional removal of a never-supported piece of code is not a #regression imho. TASK DETAIL https://phabricator.wikimedia.org/T259211 EMAIL

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-03 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Could you please help me understand what you'd like to do that is no longer possible now to achieve what? That'd at least help me figure out how to move on with this. Thanks! TASK DETAIL https://phabricator.wikimedia.org/T259211 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-02 Thread eranroz
eranroz added a project: Regression. TASK DETAIL https://phabricator.wikimedia.org/T259211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: eranroz Cc: Krinkle, Lucas_Werkmeister_WMDE, Ladsgroup, Aklapper, eranroz, Akuckartz, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-02 Thread Ladsgroup
Ladsgroup added a comment. > Also I don't agree with the arguments on heavy load - RepoApi can be lazy loaded on user action - upon pressing on linkitem. Please read the blog post, the cost of **registering** a module is big specially on all of wikipedia even if it doesn't end up

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-08-02 Thread eranroz
eranroz added a comment. I don't find RepoApi as bad module - it get in the constructor the repository - repository could be Wikidata, or Commons or other Wikibase site. Also I don't agree with the arguments on heavy load - RepoApi can be lazy loaded on user action - upon pressing on

[Wikidata-bugs] [Maniphest] T259211: wikibase RepoApi disappeared

2020-07-30 Thread matej_suchanek
matej_suchanek added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T259211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Krinkle, Lucas_Werkmeister_WMDE, Ladsgroup, Aklapper, eranroz, Akuckartz,