[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2022-10-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE merged a task: T108533: [Bug] Escaping problem when 
creating an item from search.
Lucas_Werkmeister_WMDE added subscribers: Multichill, Envlh, TerraCodes, 
IvanFon.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Lucas_Werkmeister_WMDE
Cc: IvanFon, TerraCodes, Envlh, Multichill, LucasWerkmeister, matej_suchanek, 
Ayack, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Iflorez, alaa_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-18 Thread matej_suchanek 
matej_suchanek closed this task as "Resolved".
matej_suchanek added a comment.


  > For Lexemes, the lemma is still escaped, but that seems to be due to the 
`{{PAGENAME:}}` magic word, which also wikitext-escapes its argument 
,
 and would require a different fix.
  
  I will take a look, it should be possible to fix it locally.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, matej_suchanek
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-10 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I edited the Test Wikidata message 
 and it seems to 
work as expected now, at least for Items. (For Lexemes, the lemma is still 
escaped, but that seems to be due to the `{{PAGENAME:}}` magic word, which also 
wikitext-escapes its argument 
,
 and would require a different fix.)

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Lucas_Werkmeister_WMDE
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-10 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I would wait at least until Friday in case the train rolls back. But you 
should be able to test the behavior with `{{` etc. on Test Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Lucas_Werkmeister_WMDE
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-10 Thread matej_suchanek 
matej_suchanek added a comment.


  wmf.21 is out, so I think we can apply it. But I'm afraid it will now be 
possible to break this with stuff like `{{` or `}}`.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, matej_suchanek
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-03 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Maintenance_bot
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Once wmf.21 has rolled out (sometime next week or the the week after), an 
interface admin 
 can update 
MediaWiki:search-nonefound 
, and then we can 
move this to Verification. (Maybe I’ll remember to leave an {{edit request}}.)

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Lucas_Werkmeister_WMDE
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-03 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, ReleaseTaggerBot
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-03 Thread gerritbot 
gerritbot added a comment.


  Change 643075 **merged** by jenkins-bot:
  [mediawiki/core@master] Add unescaped term as argument to search-nonefound 
messages
  
  https://gerrit.wikimedia.org/r/643075

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, gerritbot
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-02 Thread WMDE-leszek 
WMDE-leszek edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, WMDE-leszek
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-12-01 Thread Lydia_Pintscher 
Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Lydia_Pintscher
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-11-25 Thread Lydia_Pintscher 
Lydia_Pintscher added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Lydia_Pintscher
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-11-23 Thread LucasWerkmeister 
LucasWerkmeister claimed this task.
LucasWerkmeister added a comment.


  I tested the above patch locally with the following version of the 
`search-nonefound` message (adapted from the Wikidata version):
  
There were no results matching the query.

{{#switch:{{NAMESPACENUMBER:$1}}
|122=You may [[Special:MyLanguage/Project:Property proposal|propose a new 
property]].
|146=You may 
[{{fullurl:Special:NewLexeme|lemma={{urlencode:{{#switch:{{ucfirst:$2}}
 |L:{{PAGENAME:$2}}
 |Lexeme:{{PAGENAME:$1}}={{PAGENAME:$2}}
 |#default={{lcfirst:{{PAGENAME:$2
}}|PATH create a new lexeme] for "{{#switch:{{ucfirst:$1}}
 |L:{{PAGENAME:$1}}
 |Lexeme:{{PAGENAME:$1}}={{PAGENAME:$1}}
 |#default={{lcfirst:{{PAGENAME:$1
}}".
|#default=You may [{{fullurl:Special:NewItem|label={{urlencode:$2|PATH 
create a new item] for "$1".
}}
  
  Seems to work like a charm.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister
Cc: LucasWerkmeister, matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-11-23 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-11-23 Thread gerritbot 
gerritbot added a comment.


  Change 643075 had a related patch set uploaded (by Lucas Werkmeister; owner: 
Lucas Werkmeister):
  [mediawiki/core@master] Add unescaped term as argument to search-nonefound 
messages
  
  https://gerrit.wikimedia.org/r/643075

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-09-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  While this issue arises from the on-wiki-overridden interface message (and 
therefore arguably isn’t the responsibility of the Wikidata development team), 
I think it requires a fix at the software level. Specifically, the 
Special:Search page wikitext-escapes the search term before sending it to the 
interface message:
  
  name=SpecialSearch.php
// If we have no results and have not already displayed an error message
if ( $num === 0 && !$hasSearchErrors ) {
$out->wrapWikiMsg( "\n$1", [
$hasOtherResults ? 'search-nonefound-thiswiki' : 
'search-nonefound',
wfEscapeWikiText( $term )
] );
}
  
  I’m not aware of any way for the interface message to undo this escaping, so 
that it can put the original search term in the URL. My suggestion is to the 
unescaped search term as a second parameter to the message: it would be unused 
by default, but the Wikidata version of the message could use $2 to build the 
link (while still displaying the original, escaped $1).

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T263258: “Create a new item” link on search results page can produce incorrectly-escaped label

2020-09-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added a project: Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As a Wikidata editor, when I search for a label and find no matching item, I 
want to create a new item for this label, in order to use that new item e. g. 
in a statement elsewhere.
  
  **Problem:**
  On Wikidata, the search page includes a link to Special:NewItem if there are 
no search results, with the label for the new item pre-filled with the search 
term. (This is done by customizing an interface message at 
MediaWiki:search-nonefound 
.) However, sometimes 
the label is escaped incorrectly; namely, an apostrophe turns into “”.
  
  This issue was first reported on the contact the development team page 

 (permanent link 
).
  
  **Example:**
  Example search link 

  
  **Screenshots/mockups:**
  
  **BDD**
  GIVEN 
  AND 
  WHEN
  AND
  THEN
  AND
  
  **Acceptance criteria:**
  
  - The “create a new item” link on the search page always produces the correct 
label (the one that the user entered).
  
  **Open questions:**

TASK DETAIL
  https://phabricator.wikimedia.org/T263258

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: matej_suchanek, Ayack, Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs