[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2021-01-24 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher added a comment. I checked it again now and the addStatementUsage part takes 860 ms. While this is still large and we should improve it I am going to close this ticket because the spike seems to be gone and have been an issue

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-22 Thread toan
toan added a comment. We discussed the way forward for this task this morning and decided we will not spend more time investigate what could have been the root cause now ( even though it would be very satisfying ) but keep this ticket on the board and monitor if there any changes in the

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-22 Thread RolandUnger
RolandUnger added a comment. I was surprised, too. And I did not made any changes (yesterday morning I only added some maintenance categories). The computing times for `addStatementUsage` oscillate (between 400 and 900 ms) but they are clearly reduced. I think yesterday the 1.36.0-wmf.14

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-22 Thread toan
toan added a subscriber: Tarrow. toan added a comment. I did some more tests with @Tarrow yesterday evening and seems this might just have been noise as we could not reproduce it again. Looking at the profile of https://de.wikivoyage.org/wiki/Halle_(Saale) this morning there is a

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-21 Thread RolandUnger
RolandUnger added a comment. The computing times for `Scribunto_LuaSandboxCallback::getEntity` and `Scribunto_LuaSandboxCallback::addStatementUsage` did not change much, but only that of `Scribunto_LuaSandboxCallback::addStatementUsage` changed drastically. The number of properties fetched

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-21 Thread toan
toan added a comment. Ok, so after looking at this yesterday and today I've tried to replicate my local environment to what has been and what currently is deployed on https://de.wikivoyage.org/wiki/Spezial:Version LuaSandbox3.0.3 Lua 5.1.5 Installing luasandbox for

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-21 Thread RolandUnger
RolandUnger added a comment. I am not sure if T263999 is the real cause for this bug. But I cannot exclude this cause, or maybe both bugs have a joint cause elsewhere. `addStatementUsage` only registers the use of an entity and a property and has

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-20 Thread toan
toan added a comment. > Leaving T263999 : Some lua-calls with language specified does not end up in formatterCache because it has similar buzz words but I don't know if they are related. Yeah I'm suspecting this could be the culprit ( or

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-20 Thread Pablo-WMDE
Pablo-WMDE added a comment. Leaving T263999: Some lua-calls with language specified does not end up in formatterCache because it has similar buzz words but I don't know if they are related. TASK DETAIL https://phabricator.wikimedia.org/T265562

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-20 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T265562 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Lucas_Werkmeister_WMDE, toan, hoo, Lydia_Pintscher, RolandUnger, Aklapper, Akuckartz, Iflorez, darthmon_wmde,

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-20 Thread ItamarWMDE
ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T265562 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Lucas_Werkmeister_WMDE, toan, hoo, Lydia_Pintscher, RolandUnger, Aklapper, Akuckartz,

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-20 Thread ItamarWMDE
ItamarWMDE renamed this task from "Wikibase Lua: addStatementUsage seems unjustifiably expensive" to "[6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive". TASK DETAIL https://phabricator.wikimedia.org/T265562 EMAIL PREFERENCES