[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[thiemowmde]

thiemowmde added a comment.


  I feel like we need to talk about this a little more.
  
  > We call them the Wikimedia coding standards.
  
  Yes, and no. Sure, one of the purposes of the #mediawiki-codesniffer 
 is to encode 
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP. But the two are 
not entirely identical. The manual page lists things that aren't or just can't 
be checked by a sniff (for example, it's probably impossible to tell if a `==` 
should be a `===` or vice versa). And we have more and more sniffs for details 
that are not listed on the manual page. For example, the manual page doesn't 
say anything about `assertCount` and such – yet we have sniffs that discourage 
using certain combinations.
  
  That alone is not a problem.
  
  We typically think of a coding standard as something that should ideally 
apply to 100% of all code. When code doesn't conform, it should probably be 
rewritten. But here is the problem: We started to add more and more sniffs with 
known exceptions that are not "broken" and don't need "fixing". Other sniffs 
are disputable. For example, I think that the extra space in `@param bool   
$enable` really, really isn't a problem (this happens when you vertically align 
multiple @param). It should be ok when the owner of a codebase excludes this. 
T264948  is a another example that 
already caused issues, see T269332 . 
Is this a problem? Shouldn't be. We have know solutions, e.g. using `// 
phpcs:…` comments or ``, as discussed above. But it can become an 
issue when a sniff's message or a tool like #libup 
 create the impression that the 
owner of a codebase is doing something wrong – when they don't. It's about the 
tone. That's why I hope we can do more fine-tuning like this 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, thiemowmde
Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, 
Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, 
Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[WMDE-leszek]

WMDE-leszek closed this task as "Resolved".
WMDE-leszek moved this task from Test (Verification) to Done on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, WMDE-leszek
Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, 
Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, 
Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[WMDE-leszek]

WMDE-leszek updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, WMDE-leszek
Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, 
Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, 
Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[WMDE-leszek]

WMDE-leszek updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, WMDE-leszek
Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, 
Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, 
Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Addshore]

Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞) board.
Addshore added a comment.


  https://github.com/wmde/WikibaseDataModel/pull/837
  https://github.com/wmde/WikibaseDataModelSerialization/pull/259
  https://github.com/wmde/WikibaseDataModelServices/pull/243
  https://github.com/wmde/WikibaseInternalSerialization/pull/134
  
  https://github.com/wmde/WikibaseCodeSniffer/pull/59

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, 
Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, 
Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Addshore]

Addshore claimed this task.
Addshore moved this task from Test (Verification) to Doing on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, 
Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, 
Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[WMDE-leszek]

WMDE-leszek reopened this task as "Open".
WMDE-leszek added a comment.


  This does not seem completed in  way WMDE wanted it. Please let us finish it 
and close it when we're done.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, 
Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, 
Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Addshore]

Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, Jdforrester-WMF, 
thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, Iflorez, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Addshore]

Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, Jdforrester-WMF, 
thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, Iflorez, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Addshore]

Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, Jdforrester-WMF, 
thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, Iflorez, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Umherirrender]

Umherirrender closed this task as "Resolved".
Umherirrender added a comment.


  Everything on gerrit is done, some repos on github seems still to use it: 
https://codesearch.wmcloud.org/search/?q=wikibase-codesniffer=nope==

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender
Cc: Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, Jdforrester-WMF, 
thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, Iflorez, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Jdforrester-WMF]

Jdforrester-WMF added a subscriber: Umherirrender.
Jdforrester-WMF added a comment.


  The "correct" way to do this is like @Umherirrender did on this patch 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/646637

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, Jdforrester-WMF, 
thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, Iflorez, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Legoktm]

Legoktm added a comment.


  In T266823#6672755 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Well, the first round of LibUp 
-powered phpcs updates is now on 
Gerrit, and I’m not exactly impressed… judging from 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/646637,
 it doesn’t look like LibUp is currently written in such a way as to respect 
permanent, deliberate exclusions from the ruleset; rather, the intention seems 
to be that all projects must adhere to the full ruleset, and any exclusions are 
only temporary because they can’t be autofixed yet – as soon as a human fixes 
them, or they become autofixable, the exclusion is removed from the config.
  
  For those most part that's how it's generally worked. libup works by swapping 
in a blank config with no rules disabled, autofixing whatever is possible, then 
restoring the old config and removing whatever now passes. We'll need to have 
it respect `0` as the explicit way to disable something 
that isn't supposed to be fixed.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm
Cc: Legoktm, Lucas_Werkmeister_WMDE, Jdforrester-WMF, thiemowmde, Aklapper, 
Michael, Ladsgroup, Addshore, Akuckartz, Iflorez, alaa_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  In T266823#6672755 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Well, the first round of LibUp 
-powered phpcs updates is now on 
Gerrit, and I’m not exactly impressed… judging from 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/646637,
 it doesn’t look like LibUp is currently written in such a way as to respect 
permanent, deliberate exclusions from the ruleset; rather, the intention seems 
to be that all projects must adhere to the full ruleset, and any exclusions are 
only temporary because they can’t be autofixed yet – as soon as a human fixes 
them, or they become autofixable, the exclusion is removed from the config.
  
  Yes. We call them the Wikimedia coding standards. :-)

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Lucas_Werkmeister_WMDE, Jdforrester-WMF, thiemowmde, Aklapper, Michael, 
Ladsgroup, Addshore, Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Well, the first round of LibUp 
-powered phpcs updates is now on 
Gerrit, and I’m not exactly impressed… judging from 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/646637,
 it doesn’t look like LibUp is currently written in such a way as to respect 
permanent, deliberate exclusions from the ruleset; rather, the intention seems 
to be that all projects must adhere to the full ruleset, and any exclusions are 
only temporary because they can’t be autofixed yet – as soon as a human fixes 
them, or they become autofixable, the exclusion is removed from the config.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Jdforrester-WMF, thiemowmde, Aklapper, Michael, 
Ladsgroup, Addshore, Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T268827: Wikibase: Replace 
wikibase-codesniffer with mediawiki-codesniffer v33  as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Legoktm]

Legoktm added a parent task: T269464: Release MediaWiki CodeSniffer 34.0.0.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T268828: WikibaseCirrusSearch: Replace 
wikibase-codesniffer with mediawiki-codesniffer v33  as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T268826: EntitySchema: Replace 
wikibase-codesniffer with mediawiki-codesniffer v33  as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T268830: WikibaseLexemeCirrusSearch: 
Replace wikibase-codesniffer with mediawiki-codesniffer v33  as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T268829: WikibaseLexeme: Replace 
wikibase-codesniffer with mediawiki-codesniffer v33  as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T268831: WikibaseQualityConstraints: 
Replace wikibase-codesniffer with mediawiki-codesniffer v33  as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[ItamarWMDE]

ItamarWMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[ItamarWMDE]

ItamarWMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Jakob_WMDE]

Jakob_WMDE moved this task from Prioritized Tech (prioritised from top to 
bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Jakob_WMDE edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[Jakob_WMDE]

Jakob_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer

[WMDE-leszek]

WMDE-leszek renamed this task from "Use mediawiki codesniffer v33 and retire 
wikibase-codesniffer" to "Use mediawiki codesniffer v33 in actively developed 
Wikibase related repositories and retire wikibase-codesniffer".
WMDE-leszek updated the task description.
WMDE-leszek set the point value for this task to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, 
Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs