[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Ladsgroup]

Ladsgroup closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Ladsgroup
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[gerritbot]

gerritbot added a comment.


  Change 655906 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Fix directions of Sense Gloss 
inputs
  
  https://gerrit.wikimedia.org/r/655906

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Ladsgroup]

Ladsgroup added a comment.


  I confirm the patch fixes both issues:
  F33997945: image.png 
  F33997947: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Ladsgroup
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Ladsgroup]

Ladsgroup added a comment.


  In T271937#6744007 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > @Ladsgroup I assume those language inputs should //all// be RTL, since they 
contain Persian language names?
  
  Funnily enough, they have the language code in latin letters, making it bidi 
but given that the name is the major part, I think it should be RTL.

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Ladsgroup
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[gerritbot]

gerritbot added a comment.


  Change 655906 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/WikibaseLexeme@master] Fix directions of Sense Gloss 
inputs
  
  https://gerrit.wikimedia.org/r/655906

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Apparently the inputs are even LTR with ?uselang=fa (presumably because the 
styles use the site language, not the interface language):
  F33997843: Screenshot_2021-01-13 Luftballon(2).png 

  @Ladsgroup I assume those language inputs should //all// be RTL, since they 
contain Persian language names?

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Lexicographical data, 
RTL.
Restricted Application added a subscriber: Huji.
Restricted Application added a project: I18n.

TASK DESCRIPTION
  As an editor working on lexicographical data, when editing Glosses of a Sense 
in an RTL language I want the input to be in RTL, in order to enter it without 
breaking my brain.
  
  **Problem:**
  The directionality of a Gloss is set correctly when displaying it (T203081 
), but not when editing it.
  
  **Example:**
  See the Persian or Hebrew Glosses of L99-S1 
.
  
  **Screenshots/mockups:**
  F33997823: Screenshot_2021-01-13 Luftballon.png 

  F33997825: Screenshot_2021-01-13 Luftballon(1).png 

  
  **BDD**
  GIVEN a Sense on a Lexeme
  WHEN I edit an existing Gloss in an RTL language
  OR I add a new Gloss in an RTL language
  THEN the input is aligned right-to-left
  
  **Acceptance criteria:**
  
  - The input is styled correctly.
  
  **Notes:**
  
  This happens because the `` is selected by the following CSS rule:
  
.sitedir-ltr textarea, .sitedir-ltr input, textarea[dir="ltr"][dir="ltr"], 
input[dir="ltr"][dir="ltr"] {
direction: ltr;
}
  
  Which comes from this LESS code in 
`resources/src/mediawiki.skinning/legacy.less`:
  
/* Most input fields should be in site direction */
textarea,   



   
input {
// Doubling of `dir` attribute selector increases specificity to allow  



   
// attributes to override content and/or site directionality. See 
T260993.


 
.sitedir-ltr &, 



   
&[ dir='ltr' ][ dir='ltr' ] {
/* @noflip */
direction: ltr;
}

.sitedir-rtl &, 



   
&[ dir='rtl' ][ dir='rtl' ] {
/* @noflip */
direction: rtl;
}
}

TASK DETAIL
  https://phabricator.wikimedia.org/T271937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Amire80, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs