[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[Ladsgroup]

Ladsgroup moved this task from Ready to pick up to Done on the Wikidata Query 
Builder board.
Ladsgroup closed this task as "Resolved".
Ladsgroup added a comment.


  We are migrating to gerrit (T277060: Move the Query Builder repository to 
Gerrit ). This is done.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Addshore, sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, maantietaja, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
valerio.bozzolan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wong128hk, Luke081515, abian, Wikidata-bugs, aude, 
Bawolff, Grunny, csteipp, Mbch331, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[Michael]

Michael added a parent task: T277060: Move the Query Builder repository to 
Gerrit.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Addshore, sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, maantietaja, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
valerio.bozzolan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wong128hk, Luke081515, abian, Wikidata-bugs, aude, 
Bawolff, Grunny, csteipp, Mbch331, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[sbassett]

sbassett added a comment.


  In T272130#6802796 , 
@Addshore wrote:
  
  > So, this will be deployed via a build in jenkins (ideally), so that it uses 
the same process and the query gui.
  > This is just about to be created by the campsite as a push button trigger 
in https://phabricator.wikimedia.org/T210286
  > I guess it's only for a similar job to exist fetching code from github to 
create the build that would then be deployed?
  >
  > Another alternative would be github actions to make the build and push a 
change to gerrit?
  > I don't see a big difference between the two as either way the build is 
triggered by a human, and the change is still 2ed by a human.
  > The one difference would be that npm install is running in a different 
place for each.
  
  While not ideal, I think either of these approaches would be fairly low risk 
given the current realities of how code with build steps has to be managed and 
deployed to Wikimedia production, especially if said code's canonical repo 
exists outside of gerrit.  And obviously any QA and/or security-minded review 
which can happen post-build (automated or otherwise) is strongly encouraged, 
prior to deployment.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: sbassett
Cc: Addshore, sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, 
Mbch331, Rxy, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[Addshore]

Addshore added a comment.


  In T272130#6792307 , 
@sbassett wrote:
  
  > @Ladsgroup @Michael -  The #security-team 
 discussed this task this 
morning.  Is the plan to pull from github for deployments upon Wikimedia 
production hardware?  If so, I believe #sre 
 does not allow for that.
  
  Not quite, here is the summary
  
  So, this will be deployed via a build in jenkins (ideally), so that it uses 
the same process and the query gui.
  This is just about to be created by the campsite as a push button trigger in 
https://phabricator.wikimedia.org/T210286
  I guess it's only for a similar job to exist fetching code from github to 
create the build that would then be deployed?
  
  Another alternative would be github actions to make the build and push a 
change to gerrit?
  I don't see a big difference between the two as either way the build is 
triggered by a human, and the change is still 2ed by a human.
  The one difference would be that npm install is running in a different place 
for each.
  
  > For original development, it made sense since the CI was pretty easy to 
setup
  
  I don't think there is anything that different to normal CI things for this 
repository that would make it hard to run in jenkins (but I could be wrong)

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, 
Mbch331, Rxy, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[Ladsgroup]

Ladsgroup added a comment.


  Let's migrate it once we migrated the browser tests to cypress.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, 
Mbch331, Rxy, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[Michael]

Michael added a comment.


  @sbassett Thank you and the team so much for looking into this!
  Having certainty about the move away from GitHub allows us to make progress 
on other questions as well, and we can start the migration process now, with 
more than enough time to spare until we actually want to go live.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, 
Mbch331, Rxy, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[sbassett]

sbassett added a project: SecTeam-Processed.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: sbassett
Cc: sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, 
Mbch331, Rxy, Jay8g, Krenair, chasemp, RhinosF1
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[sbassett]

sbassett added a comment.


  @Ladsgroup @Michael

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: sbassett
Cc: sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, 
Mbch331, Rxy, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[sbassett]

sbassett added a comment.


  > Hello security team, it would be great if we can have a comment on this 
ticket on whether it's okay to have it on github or not. We are planning to 
deploy this to production as a static site.
  
  @Ladsgroup @Michael - we'll chat about this as a team at our clinic meeting 
this Monday, but I don't think we'd have too many security concerns (at least I 
don't) about canonically hosting Wikimedia-related repos at github, since we 
already do that for a handful of repos anyways (service-template-node et al).  
I believe there is a preference to use gerrit for canonical Wikimedia-related 
repos, but there's no official policy governing this AFAIK, and as long as best 
practices around development, CI and security issues are being followed, that 
should be fine.  Finally - this will all change once projects begin migrating 
to Gitlab over the next year or so.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: sbassett
Cc: sbassett, Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, 
Lydia_Pintscher, Devnull, Akuckartz, Dsharpe, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, 
Mbch331, Rxy, Jay8g, Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: Consider moving the Wikidata Query Builder repository from github to gerrit

[Aklapper]

Aklapper renamed this task from "consider moving the repository from github to 
gerrit" to "Consider moving the Wikidata Query Builder repository from github 
to gerrit".

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Aklapper
Cc: Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, 
Devnull, Akuckartz, Dsharpe, Nandana, sbassett, Lahi, Gq86, GoranSMilovanovic, 
QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, Mbch331, Rxy, Jay8g, 
Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs