[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Sarai-WMDE added a comment. Hey, @abian! Thank you so much for reporting this problem. We broke it down in two issues: 1. Querying for dates with year and month precision using the condition "before" generates invalid results. The following ticket was created to address this: T280035

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

abian added a comment. According to the UI, you can retrieve people born before (or after), for example, 31 January (birthday), but what you get has nothing to do with that. I believe there are quite a few other problematic use cases (which is understandable, this is a challenging task!).

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

amy_rc moved this task from Test (Verification) to Done on the Wikidata Query Builder board. amy_rc closed this task as "Resolved". amy_rc claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T272697 WORKBOARD https://phabricator.wikimedia.org/project/board/4990/ EMAIL

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

amy_rc added a comment. tested for the BDD and ACC. \o/ TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE, Lydia_Pintscher, amy_rc, Aklapper,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE, Lydia_Pintscher, amy_rc,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

gerritbot added a comment. Change 678567 **merged** by jenkins-bot: [wikidata/query-builder@master] Fix not selecting anything with month or year precision https://gerrit.wikimedia.org/r/678567 TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

gerritbot added a comment. Change 678282 **merged** by jenkins-bot: [wikidata/query-builder@master] Ensure day precision for day values https://gerrit.wikimedia.org/r/678282 TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Sarai-WMDE added a comment. In T272697#6990424 , @Sarai-WMDE wrote: > I also noticed that we're not getting any results when queries only contain "month-year" or "year" date values (I'm assuming we want to allow this). For example,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

gerritbot added a comment. Change 678567 had a related patch set uploaded (by Michael Große; author: Michael Große): [wikidata/query-builder@master] Fix not selecting anything with month or year precision https://gerrit.wikimedia.org/r/678567 TASK DETAIL

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Sarai-WMDE added a comment. I also noticed that we're not getting any results when queries only contain "month-year" or "year" date values. For example, this query should find at least the First Balkan war . This applies

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

amy_rc closed subtask T273002: (MS 6) Create Date input component as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael moved this task from Test (Verification) to Peer Review on the Wikidata Query Builder board. Michael added a comment. When verifying, @Sarai-WMDE noticed that we are getting year-precision results for day values: https://w-beta.wmflabs.org/HW The patch

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

gerritbot added a comment. Change 678282 had a related patch set uploaded (by Michael Große; author: Michael Große): [wikidata/query-builder@master] Ensure day precision for day values https://gerrit.wikimedia.org/r/678282 TASK DETAIL https://phabricator.wikimedia.org/T272697

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE, Lydia_Pintscher, amy_rc, Aklapper, Invadibot,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael closed subtask T277854: Ensure that link-sharing still works with Date Queries as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Sarai-WMDE, abian,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael closed subtask T277850: Create DateValueInput component as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael closed subtask T277039: (MS 6) create SPARQL for date queries as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael moved this task from Ready to pick up to Test (Verification) on the Wikidata Query Builder board. Michael added a comment. Querying for date values can now be verified on the toolforge test-system ! TASK DETAIL

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael closed subtask T277853: Wire up DateValueInput and create browser tests as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael closed subtask T277848: Create an action for the DateValueInput to call on user input as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Sarai-WMDE, abian,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

amy_rc closed subtask T277851: Adjust QueryRepresentation to include DateValue as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

amy_rc closed subtask T277847: Adjust the RootState to store the parsed value as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: Michael, Sarai-WMDE, abian, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher closed subtask T277038: (MS 6) Create ParseValueRepository as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Michael, Sarai-WMDE, abian,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher closed subtask T277057: (MS 6) Create FormatValueRepository as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Michael, Sarai-WMDE, abian,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael added a comment. In T272697#6931299 , @Lydia_Pintscher wrote: > In T272697#6927889 , @Michael wrote: > >> In T272697#6910845

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher added a comment. In T272697#6927889 , @Michael wrote: > In T272697#6910845 , @Lydia_Pintscher wrote: > >>> We only support 3 degrees of precision: day, month, year

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Michael renamed this task from "(MS 6)  Query for date values" to "(MS 6) Query for date values". TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Sarai-WMDE, abian,

[Wikidata-bugs] [Maniphest] T272697: (MS 6)  Query for date values

Michael added a comment. In T272697#6910845 , @Lydia_Pintscher wrote: >> We only support 3 degrees of precision: day, month, year > > Can we clarify why only those 3? IIRC, because you said so :) TASK DETAIL

[Wikidata-bugs] [Maniphest] T272697: (MS 6)  Query for date values

Lydia_Pintscher added a comment. > We only support 3 degrees of precision: day, month, year Can we clarify why only those 3? TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T272697: (MS 6)  Query for date values

Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Sarai-WMDE, abian, Charlie_WMDE, Lydia_Pintscher, amy_rc, Aklapper, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T272697: (MS 6)  Query for date values

Michael renamed this task from "(MS 6) Query for date values" to "(MS 6)  Query for date values". Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher set the point value for this task to "13". TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Sarai-WMDE, abian, Charlie_WMDE, Lydia_Pintscher, amy_rc, Aklapper,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

abian added a comment. In T272697#6875288 , @Sarai-WMDE wrote: > Hey, @abian. Those are very valid and concerns, and we really appreciate you sharing them! We are aware that unfortunately some current issues will also be reproduced by

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Sarai-WMDE added a comment. Hey, @abian. Those are very valid and concerns, and we really appreciate you sharing them! We are aware that unfortunately some current issues will also be reproduced by the new application (e.g. querying for a specific date like 01-01-2021 will result in false

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

abian added a comment. Hey over here. I'm writing to warn you that, unfortunately, this can be extremely problematic. Since Wikibase stores all dates with day precision, regardless of their actual precision (which is stored separately), and the irrelevant part of the value can be arbitrary,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Charlie_WMDE removed Charlie_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Charlie_WMDE, Lydia_Pintscher, amy_rc, Aklapper, Akuckartz,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE, Sarai-WMDE Cc: Lydia_Pintscher, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Charlie_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Lydia_Pintscher, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher assigned this task to Charlie_WMDE. Lydia_Pintscher added a comment. Assigning to Charlie for adding mockups TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher added a subtask: T273002: Create Point in time input component. TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, amy_rc, Aklapper, Akuckartz,

[Wikidata-bugs] [Maniphest] T272697: (MS 6) Query for date values

Lydia_Pintscher renamed this task from "(MS 6) Input date values" to "(MS 6) Query for date values". TASK DETAIL https://phabricator.wikimedia.org/T272697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, amy_rc,