[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

gerritbot added a comment. Change 692264 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] Hard-deprecate DBAccessBase class https://gerrit.wikimedia.org/r/692264 TASK DETAIL

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE added a comment. In that case I guess we go ahead with hard deprecation immediately. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Addshore,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE added a comment. > I assume at least the soft-deprecation can be backported to MediaWiki 1.36 as well? Apparently not. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Addshore, daniel, Pchelolo, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

gerritbot added a comment. Change 683819 **merged** by jenkins-bot: [mediawiki/core@master] Soft-deprecate DBAccessBase class https://gerrit.wikimedia.org/r/683819 TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Addshore added a comment. Related T281453: Abstract database connections between Client and Repository TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE removed a project: Wikibase Service Migration. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, Lalamarie69,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: daniel, Pchelolo, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, Lalamarie69, maantietaja,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

gerritbot added a comment. Change 683819 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): [mediawiki/core@master] Soft-deprecate DBAccessBase class https://gerrit.wikimedia.org/r/683819 TASK DETAIL

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE added a comment. Wikibase no longer uses `DBAccessBase`, so I assume the class can now be soft-deprecated in core, and then hard-deprecated and eventually removed later. I’m not sure if we’ll backport all the Wikibase changes to `REL1_36`, but I assume at least

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE closed subtask T281114: Stop using DBAccessBase in PropertyInfoTable as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: daniel,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE closed subtask T281115: Stop using DBAccessBase in SiteLinkTable as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: daniel, Pchelolo,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE closed subtask T281113: Stop using DBAccessBase in EntityChangeLookup as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: daniel,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE closed subtask T281116: Stop using DBAccessBase in WikiPageEntityMetaDataLookup as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE closed subtask T281117: Stop using DBAccessBase in WikiPageEntityRevisionLookup as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE closed subtask T281118: Stop using DBAccessBase in SqlSiteLinkConflictLookup as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: daniel,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering. daniel triaged this task as "Low" priority. daniel added a comment. Not high prio for the PET team, but if anyone wants to take it on, please do :) TASK DETAIL

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

daniel added a comment. Yea, it's not good to use a base class for this. It should be a trait, or just be removed. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, Pchelolo,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Pchelolo added a subscriber: daniel. Pchelolo added a comment. cc @Daniel as original author. TASK DETAIL https://phabricator.wikimedia.org/T279063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pchelolo Cc: daniel, Pchelolo,

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Pchelolo added a comment. I think we can go even further and just eliminate the class entirely. It provides no value - it has 3 lines of very simple code in it, no other classes seem to have methods typed with "DBConnectionBase" - zero value. For marking value objects that 'belong to a

[Wikidata-bugs] [Maniphest] T279063: DBAccessBase is difficult to use with dependency injection

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikimedia-Rdbms, Wikidata, Wikibase Service Migration. Restricted Application added a subscriber: Aklapper. Restricted Application added projects: Platform Engineering, wdwb-tech. TASK DESCRIPTION `DBAccessBase`